add outer try-catch fix issue #545 #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svg153
approved these changes
Nov 21, 2023
bheemvennapureddy
approved these changes
Dec 7, 2023
svg153
suggested changes
Dec 7, 2023
Comment on lines
-789
to
+814
| rulesets: require('./plugins/rulesets'), | ||
| environments: require('./plugins/environments') | ||
| rulesets: require('./plugins/rulesets') |
There was a problem hiding this comment.
Why this change? Did you remove the environments plugin ?
|
Oh! Sorry. I must’ve accidentally removed it. Can you create a pR and I’ll
merge it. I am traveling and using my phone so it would be easier that way.
On Fri, Dec 8, 2023 at 7:11 AM Sergio Valverde ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/settings.js
<#546 (comment)>:
> - rulesets: require('./plugins/rulesets'),
- environments: require('./plugins/environments')
+ rulesets: require('./plugins/rulesets')
@decyjphr <https://github.com/decyjphr> did you remove the environments
plugin ?
—
Reply to this email directly, view it on GitHub
<#546 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANXBBBTPECPPGRGU7UQ6USTYIJV4DAVCNFSM6AAAAAA6YIHNBSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONZRGQYTMNBVGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Yadhav Jayaraman,
Github Expert Services
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pendingstatenull