Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] align dev deps with relative-time #32

Closed
wants to merge 9 commits into from
Closed

Conversation

jdanyow
Copy link

@jdanyow jdanyow commented Jan 31, 2023

#31

@jdanyow jdanyow requested a review from a team as a code owner January 31, 2023 14:12
@jdanyow
Copy link
Author

jdanyow commented Jan 31, 2023

Not ready for review- tests aren't quite working yet. Just opening in case alignment with relative-time's setup is not the way to go with this. It looked like the most recently updated element package setup.

@jdanyow jdanyow marked this pull request as draft January 31, 2023 14:22
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

@keithamus
Copy link
Member

Aligning with relative-time would be great 👍

@jdanyow jdanyow closed this Jun 21, 2024
@jdanyow jdanyow deleted the deps branch June 21, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants