Skip to content

Conversation

@Arminius
Copy link

Reasons for making this change:

vcpkg running in manifest mode will create a folder vcpkg_installed/ containing installed package files that should not be committed to any project.

Links to documentation supporting these rule changes:

The manifest mode of vcpkg is documented at https://learn.microsoft.com/en-us/vcpkg/users/manifests

vcpkg running in manifest mode will create a folder vcpkg_installed/ containing installed package files that should not be committed to any project.
@github-actions
Copy link

github-actions bot commented Jun 9, 2025

This PR is stale because there have been no updates in 90 days. It will close after 180 days of inactivity. Leave a comment if you want to keep it open 😄

@github-actions github-actions bot added the stale label Jun 9, 2025
@github-actions
Copy link

github-actions bot commented Dec 6, 2025

This PR has been closed because it was inactive for 180 days. If you want to continue working on it, please open a new PR.

@github-actions github-actions bot closed this Dec 6, 2025
@jackpoz
Copy link

jackpoz commented Jan 13, 2026

@thorrsson sadly this PR got autoclosed because no review was done in 2 years, and vcpkg_installed/ still needs to be added manually to every new C++ repo when copying the VS .gitignore .

Would it be possible to merge this ?

@thorrsson
Copy link
Collaborator

Hey @jackpoz Yeah unfortunately we had a lot of PRs languish. The stalebot introduction was meant to help clean that up. Would you be able to create a new PR for this and tag me in it? I'll happily review it for you

@jackpoz
Copy link

jackpoz commented Jan 13, 2026

@thorrsson I see that the repo of this PR got deleted, otherwise it would have been easier to just reopen this PR.

Maybe it's better to review #4752 ? I see that that PR has the same changes as this one, plus some more useful ones.

Otherwise I will open a copy of this PR.

@thorrsson
Copy link
Collaborator

I see that the repo of this PR got deleted, otherwise it would have been easier to just reopen this PR.

Yep, I couldn't reopen it because of this

I'll take a look at #4752. Thanks for the follow up @jackpoz

@thorrsson
Copy link
Collaborator

Done, @jackpoz #4752 is merged now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants