Skip to content

Commit

Permalink
Merge pull request #389 from github/close-sync-with-err
Browse files Browse the repository at this point in the history
fixing binlog syncer double-close()
  • Loading branch information
Shlomi Noach authored Mar 29, 2017
2 parents c1c31fb + 8405b0c commit 1b0791e
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion go/binlog/gomysql_reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,10 @@ func (this *GoMySQLReader) StreamEvents(canStopStreaming func() bool, entriesCha
}

func (this *GoMySQLReader) Close() error {
this.binlogSyncer.Close()
// Historically there was a:
// this.binlogSyncer.Close()
// here. A new go-mysql version closes the binlog syncer connection independently.
// I will go against the sacred rules of comments and just leave this here.
// This is the year 2017. Let's see what year these comments get deleted.
return nil
}

0 comments on commit 1b0791e

Please sign in to comment.