Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update no generate validation error messages for bbs2gh migrate-repo #1318

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

ArinGhazarian
Copy link
Collaborator

@ArinGhazarian ArinGhazarian commented Dec 19, 2024

Closes #1317

Description

The error messages for migration paths where archive generation is not required have not been updated since --bbs-server-url was made required. This PR updates the error message for clarification.

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

@Copilot Copilot bot review requested due to automatic review settings December 19, 2024 00:05

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@ArinGhazarian ArinGhazarian merged commit 1b2c02b into main Dec 19, 2024
28 checks passed
@ArinGhazarian ArinGhazarian deleted the fix-validate-no-generate-options-error-messages branch December 19, 2024 00:44
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 81% 72% 592
ado2gh 84% 78% 631
Octoshift 87% 76% 1345
bbs2gh 82% 76% 669
Summary 84% (7176 / 8509) 76% (1656 / 2190) 3237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: bbs2gh migrate-repo --no-ssl-verify can only be provided with BBS Server URL While Providing the URL
2 participants