Fail fast if the target GitHub repo already exists in bbs2gh migrate-repo
#1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfishback01
approved these changes
Aug 2, 2023
…-repo` Looking at our error logs, it's clear that customers frequently start Bitbucket migrations, waiting for the export to run, and then discover that the migration can't happen because the target repo already exists. This wastes a bunch of time, since Bitbucket archive generation can be reasonably slow! This changes the behaviour of `bbs2gh migrate-repo` to match what `gei migrate-repo` does for GHES migrations: check if the target repo already exists *before* running the export. This should only happen when `migrate-repo` is run with a combination of arguments that includes GitHub credentials - so not the export-only or the export-and-download modes. Fixes #1086.
timrogers
force-pushed
the
timrogers/fix-1086
branch
from
271a79e
to
066c34e
Compare
|
hfishback01
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at our error logs, it's clear that customers frequently start Bitbucket migrations, waiting for the export to run, and then discover that the migration can't happen because the target repo already exists.
This wastes a bunch of time, since Bitbucket archive generation can be reasonably slow!
This changes the behaviour of
bbs2gh migrate-repoto match whatgei migrate-repodoes for GHES migrations: check if the target repo already exists before running the export.This should only happen when
migrate-repois run with a combination of arguments that includes GitHub credentials - so not the export-only or the export-and-download modes.Fixes #1086.
ThirdPartyNotices.txt(if applicable)