Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show reclaim-mannequin's --skip-invitation option in reclaim-mannequin --help #1081

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

timrogers
Copy link
Contributor

@timrogers timrogers commented Jul 25, 2023

We introduced support for the new --skip-invitation support for reclaim-mannequin in the CLI a couple of versions ago.

At the moment, it's hidden from our in-CLI documentation because access to the functionality is restricted by a feature flag that is only turned on for a tiny subset of users.

In the next couple of weeks, we'll be making this feature generally available. As part of that, we want to unhide this argument so it's there for all to see.

As part of this PR, I'm also updating the description so it doesn't say it's in development.

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

@timrogers timrogers self-assigned this Jul 25, 2023
@github-actions
Copy link

github-actions bot commented Jul 25, 2023

Unit Test Results

776 tests   776 ✔️  26s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 24d5b37.

♻️ This comment has been updated with latest results.

@timrogers timrogers changed the title Show reclaim-mannequin's --skip-invitation option in reclaim-mannequin --help [DNM] Show reclaim-mannequin's --skip-invitation option in reclaim-mannequin --help Jul 25, 2023
@timrogers
Copy link
Contributor Author

@hfishback01 I'd love to get an initial review on this from you. It'll no doubt require rebasing and conflict resolution later before we merge on August 7th, but I'd still like to get a quick review now 🙏🏻

Copy link
Contributor

@hfishback01 hfishback01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see this go through :)

@timrogers timrogers changed the title [DNM] Show reclaim-mannequin's --skip-invitation option in reclaim-mannequin --help Show reclaim-mannequin's --skip-invitation option in reclaim-mannequin --help Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Code Coverage

Package Line Rate Branch Rate Complexity Health
Octoshift 86% 75% 1216
ado2gh 84% 81% 601
gei 80% 72% 496
bbs2gh 79% 74% 622
Summary 83% (6522 / 7851) 76% (1477 / 1948) 2935

@timrogers timrogers merged commit e87b3cc into main Aug 2, 2023
30 checks passed
@timrogers timrogers deleted the timrogers/unhide-skip-invitation branch August 2, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants