Prevent LFS hook failures during safe-output bundle creation by Copilot · Pull Request #56499 · github/gh-aw

Copilot · 2026-08-28T03:43:51Z

Filtered safe-output bundle generation could fail when repositories configure Git LFS or other repository hooks unavailable in the safe-output environment.

Hook isolation: Apply the temporary core.hooksPath override to git bundle create, matching the existing worktree and git am operations.
Result: Internal bundle synthesis no longer executes repository hooks.

execGitSync([
  ...noHooksArgs,
  "bundle",
  "create",
  bundlePath,
  `${baseCommitSha}..HEAD`,
], { cwd: tempWorktree });

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-08-28T03:52:10Z

⚠️ Security scanning failed for Ponytail Reviewer. Review the logs for details.

Lean already. Ship.

Warning

Firewall blocked 4 domains

The following domains were blocked by the firewall during workflow execution:

ab.chatgpt.com
api.github.com
chatgpt.com
github.com

[!TIP]
api.github.com is blocked because GitHub API access uses the built-in GitHub tools by default. Instead of adding api.github.com to network.allowed, use tools.github.mode: gh-proxy for direct pre-authenticated GitHub CLI access without requiring network access to api.github.com:

tools:
  github:
    mode: gh-proxy

See GitHub Tools for more information on gh-proxy mode.

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"
    - "api.github.com"
    - "chatgpt.com"
    - "github.com"

See Network Configuration for more information.

Generated by Ponytail Reviewer for #56499

github-actions · 2026-08-28T03:52:16Z

✅ Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel skipped.

🧪 Test quality analysis by Test Quality Sentinel

github-actions · 2026-08-28T03:52:21Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions · 2026-08-28T03:52:28Z

✅ PR Code Quality Reviewer completed the code quality review.

Reviewed PR #56499: no actionable issues found in the one-line hook-isolation change, so no review comments or blocking review were needed.

🔎 Code quality review by PR Code Quality Reviewer

github-actions · 2026-08-28T03:53:51Z

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

No ADR enforcement needed: PR does not have the implementation label and has ≤100 new lines of code in business logic directories.

🏗️ ADR gate enforced by Design Decision Gate 🏗️

github-actions · 2026-08-28T03:55:59Z

Comment Memory

reviewed_at: 2026-08-28T00:00:00Z
review_event: COMMENT
top_themes:
  - no actionable findings
  - hook isolation change is consistent with surrounding logic
files_reviewed:
  - actions/setup/js/generate_git_bundle.cjs
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · pi · gpt54 · 3.24 AIC · ⌖ 7.29 AIC · ⊞ 7K · ◷
_{Comment /review to run again}

Copilot

Pull request overview

Prevents repository hooks from affecting filtered safe-output bundle creation.

Changes:

Applies the temporary core.hooksPath override to git bundle create.

Show a summary per file

File	Description
`actions/setup/js/generate_git_bundle.cjs`	Isolates bundle creation from repository hooks.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Files reviewed: 1/1 changed files
Comments generated: 1
Review effort level: Balanced

              execGitSync([...noHooksArgs, "worktree", "add", "--detach", tempWorktree, baseCommitSha], { cwd });
              execGitSync([...noHooksArgs, "am", "--3way", patchResult.patchPath], { cwd: tempWorktree });
-              execGitSync(["bundle", "create", bundlePath, `${baseCommitSha}..HEAD`], { cwd: tempWorktree });
+              execGitSync([...noHooksArgs, "bundle", "create", bundlePath, `${baseCommitSha}..HEAD`], { cwd: tempWorktree });


github-actions

Skills-Based Review 🧠

Applied /diagnosing-bugs — this is a clean, minimal bug fix.

The single-line change correctly extends the noHooksArgs guard to bundle create, matching the existing pattern already applied to worktree add and git am on the preceding lines. Root cause is properly addressed, not just the symptom.

📋 Assessment

✅ Fix is consistent with the established noHooksArgs pattern in this function
✅ All three git operations in the try block (worktree add, am, bundle create) now share the same hook isolation
i️ No regression test added — acceptable here since this is a CJS GitHub Actions helper with no visible test harness in the diff

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet46 · 13 AIC · ⌖ 10.3 AIC · ⊞ 7.6K
_{Comment /matt to run again}

github-actions

The fix looks correct. git bundle create was the only git call in this block missing ...noHooksArgs, which could cause LFS (or other) hooks to fire and fail during bundle creation. Adding the spread is consistent with the surrounding worktree add and am calls and closes the gap cleanly.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · copilot · sonnet46 · 15.7 AIC · ⌖ 10.5 AIC · ⊞ 6.2K

github-actions · 2026-08-28T21:14:32Z

🎉 This pull request is included in a new release.

Release: v0.87.9

Fix LFS hook handling in filtered bundles

0803522

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI assigned Copilot and pelikhan Aug 28, 2026

Copilot AI changed the title ~~Fix safe outputs git handling of LFS sections~~ Prevent LFS hook failures during safe-output bundle creation Aug 28, 2026

Copilot finished work on behalf of pelikhan August 28, 2026 03:44

Copilot created this pull request from a session on behalf of pelikhan August 28, 2026 03:44 View session

Copilot AI requested a review from pelikhan August 28, 2026 03:44

pelikhan marked this pull request as ready for review August 28, 2026 03:51

Copilot AI balanced review requested due to automatic review settings August 28, 2026 03:51

Copilot started reviewing on behalf of pelikhan August 28, 2026 03:51 View session

Copilot AI reviewed Aug 28, 2026

View reviewed changes

github-actions Bot approved these changes Aug 28, 2026

View reviewed changes

This was referenced Aug 28, 2026

[aw] No-Op Runs #48838

Open

[pr-sous-chef] pr-sous-chef run report #56497

Closed

pelikhan merged commit ab8ab60 into main Aug 28, 2026
68 of 76 checks passed

pelikhan deleted the copilot/fix-safe-outputs-git-handling branch August 28, 2026 10:30

github-actions Bot mentioned this pull request Aug 29, 2026

Smoke Test: MAI-Code-1-Flash - 33222344546 #56751

Closed

Navigation Menu

Uh oh!

Prevent LFS hook failures during safe-output bundle creation - #56499

Prevent LFS hook failures during safe-output bundle creation#56499
pelikhan merged 1 commit into
mainfrom
copilot/fix-safe-outputs-git-handling

Copilot AI commented Aug 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Copilot AI commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 28, 2026

Comment Memory

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Aug 28, 2026 •

edited

Loading

github-actions Bot commented Aug 28, 2026 •

edited

Loading

github-actions Bot commented Aug 28, 2026 •

edited

Loading

github-actions Bot commented Aug 28, 2026 •

edited

Loading

github-actions Bot commented Aug 28, 2026 •

edited

Loading

github-actions Bot commented Aug 28, 2026 •

edited

Loading