Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions .github/workflows/daily-fact.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/daily-fact.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ Mine recent activity from the repository to find interesting facts. Focus on:
## Guidelines

- **Check memory first**: Skip any PR, issue, or release that already appears in the palace results from Step 0
{{#if experiments.reasoning_depth == "multi_candidate"}}
{{#if experiments.reasoning_depth == 'multi_candidate'}}
- **Multi-candidate deliberation**: Before writing, identify exactly **3 distinct candidate facts** (one PR, one issue or release, one contributor or pattern). For each candidate write one sentence on why it is novel today. Then score each candidate 1–5 on: (a) novelty vs palace memory, (b) intrinsic poetic potential. Select the highest-scoring candidate and write the verse for that one only.
{{else}}
- **Favor recent updates** but include variety - pick something interesting, not just the most recent
Expand Down
10 changes: 10 additions & 0 deletions pkg/workflow/compiler_orchestrator_frontmatter.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"os"
"path/filepath"

"github.com/github/gh-aw/pkg/console"
"github.com/github/gh-aw/pkg/logger"
"github.com/github/gh-aw/pkg/parser"
)
Expand Down Expand Up @@ -141,6 +142,15 @@ func (c *Compiler) parseFrontmatterSection(markdownPath string) (*frontmatterPar
return nil, fmt.Errorf("template condition validation failed: %w", err)
}

// Warn when experiment comparison expressions use double-quoted string literals.
// GitHub Actions expression syntax only supports single-quoted string literals, so
// the compiler converts double quotes to single quotes automatically — but authors
// should fix the source to use single quotes to keep it consistent with the output.
for _, w := range detectDoubleQuotedExperimentComparisons(result.Markdown) {
fmt.Fprintln(os.Stderr, console.FormatWarningMessage(w))
c.IncrementWarningCount()
}

log.Printf("Frontmatter: %d chars, Markdown: %d chars", len(result.Frontmatter), len(result.Markdown))

return &frontmatterParseResult{
Expand Down
2 changes: 1 addition & 1 deletion pkg/workflow/compiler_template_validation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ permissions:
strict: false
---

{{#if experiments.prompt_style == "detailed"}}
{{#if experiments.prompt_style == 'detailed'}}
detailed prompt
{{else}}
concise prompt
Expand Down
Loading