Skip to content

Rename MapToSliceMapKeys in pkg/sliceutil#31767

Merged
pelikhan merged 2 commits into
mainfrom
copilot/function-rename-pkg-sliceutil
May 12, 2026
Merged

Rename MapToSliceMapKeys in pkg/sliceutil#31767
pelikhan merged 2 commits into
mainfrom
copilot/function-rename-pkg-sliceutil

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 12, 2026

MapToSlice is ambiguous — it doesn't convey whether the slice contains keys, values, or pairs. The function returns only keys, so MapKeys matches both the intent and Go stdlib convention (maps.Keys).

Changes

  • pkg/sliceutil/sliceutil.go — renamed function and updated doc comment
  • pkg/sliceutil/README.md — updated API table
  • Tests (sliceutil_test.go, spec_test.go) — renamed test functions and updated all call sites
  • 14 call sites updated across pkg/cli/ (firewall_log.go, audit_report_render_guard.go, run_push.go, gateway_logs_render.go) and pkg/workflow/ (mcp_setup_generator.go, mcp_config_custom.go, yaml_env_helpers.go)
// Before
keys := sliceutil.MapToSlice(myMap)

// After
keys := sliceutil.MapKeys(myMap)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name developer-action-main/dist/gh-gp--log-level=error hub.com/.extrahe/opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw (http block)
    • Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name 64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/orgs/owner/actions/secrets
    • Triggering command: /usr/bin/gh gh api /orgs/owner/actions/secrets --jq .secrets[].name json' --ignore-path ../../../.pr**/*.json (http block)
    • Triggering command: /usr/bin/gh gh api /orgs/owner/actions/secrets --jq .secrets[].name /ref/tags/v9 /usr/bin/git (http block)
    • Triggering command: /usr/bin/gh gh api /orgs/owner/actions/secrets --jq .secrets[].name /repos/actions/g--ignore-path --jq (http block)
  • https://api.github.com/orgs/test-owner/actions/secrets
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name json' --ignore-path ../../../.pr**/*.json (http block)
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name h ../../../.prettierignore gh sv ock.json pkg/wornode repos/{owner}/{r/home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/.bin/pre�� (http block)
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name ithub-script/git/ref/tags/v9 sh bject.type] | @tsv 11/001/test-emptsh l_test.go x_amd64/link infocmp -1 ithub-script/git/ref/tags/v9 x_amd64/link bject.type] | @tsv g_.a --jq ache/node/24.14.xterm-color infocmp (http block)
  • https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq [.object.sha, .object.type] | @tsv -unreachable=false /tmp/go-build2525330762/b026/vet.cfg /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet ignore-path ../.gh (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq [.object.sha, .object.type] | @tsv xterm-color 370846bf5a92b8db1ccc9208 /usr/bin/infocmp g_.a (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq [.object.sha, .object.type] | @tsv mplied **/*.cjs /home/REDACTED/work/gh-aw/gh-aw/actions/node_modules/.bin/sh **/*.json set ../../../.prettixterm-color sh -c runs/20260512-190123-32559/test-3656274313/.github/workflows node (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv se 5330762/b039/vet.cfg .cfg ./../.prettieriginfocmp (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv --get-regexp ^remote\..*\.gh-resolved$ (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv he_validation.go l_workflow.go l_workflow_compilation_test.go l_workflow_permigit l_workflow_permi-C r l_workflow_secreconfig l_wo�� te '../../../**/remote.origin.url l_workflow_validation_test.go /opt/hostedtoolcache/go/1.25.8/x64/bin/gofmt /ref/tags/v9 --jq sv /opt/hostedtoolc--jq (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v5
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv itbranch_with_hyphen2488456686/001 itbranch_with_hyphen2488456686/002/work 64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv g/cli /tmp/go-build2525330762/b156/vet.cfg 9746521/b365/vet.cfg (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv xterm-color (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv te '../../../**/*.json' '!../../../pkg/workflow/-errorsas (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv REDACTED on ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /../../.prettierdocker erignore (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv /repos/actions/github-script/git/ref/tags/v9 --jq (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v8
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv runs/20260512-185837-15142/test-2226506200 -buildtags kflows/test-expires.lock.yml -errorsas -ifaceassert -nilfunc git -C r-test2256191932/existing.md show /usr/bin/git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv ithub-script/git/ref/tags/v9 ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet 1/x64/bin/node res_import_test./usr/libexec/docker/cli-plugins/docker-buildx t_schema_test.godocker-cli-plugin-metadata 64/pkg/tool/linux_amd64/vet infocmp ance�� ithub-script/git/ref/tags/v9 64/pkg/tool/linu--jq 1/x64/bin/node -unreachable=falhead /tmp/go-build252-500 9746521/b243/vet/tmp/gh-aw/aw-feature-branch.patch infocmp (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v9
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv on' --ignore-path ../../../.prettierignore (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv on' --ignore-pat- (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v9.0.0
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9.0.0 --jq [.object.sha, .object.type] | @tsv (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9.0.0 --jq [.object.sha, .object.type] | @tsv th .prettierigno-errorsas (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9.0.0 --jq [.object.sha, .object.type] | @tsv 01 (http block)
  • https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv OnlyCompiledOutpbase (original) ache/go/1.25.8/x-L ache/go/1.25.8/xnew (upstream) (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv /ref/tags/v9 --jq sv te '../../../**/infocmp (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv T-rPmiEKB gh 4441955/b429/importcfg.link /ref/tags/v9 --jq 1/x64/bin/node gnRC5-eFZgu1f/0ELBy97bxPkfrkiwhLXh/3XLIOuLPxEGBR--jq ortc�� ry=1 stmain.go 4441955/b429/_pkg_.a .prettierignore --log-level=erroapi (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv iles formatted" (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv Onlyrepos_only_wbase (original) (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv 5837-15142/test-1437099477 /tmp/go-build2525330762/b074/vet.cfg (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv te '../../../**/*.json' '!../../../pkg/workflow/js/**/*.json' --ignore-path ../../../.prettieriggh .cfg ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv te '../../../**/*.json' '!../../../pkg/workflow/-errorsas (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv /ref/tags/v9 --jq sv get --local 64/pkg/tool/linux_amd64/vet gh api /repos/actions/github-script/git/ref/tags/v9 --jq (http block)
  • https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv te '../../../**/*.json' '!../../../pkg/workflow/-errorsas nomaly.go ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv /ref/tags/v9 -f sv -f owner=github -f gh run ithub-script/git/ref/tags/v9 12345 (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv /ref/tags/v9 gh 64/pkg/tool/linux_amd64/vet /ref/tags/v9 --jq sv 64/pkg/tool/linu2 ache�� /usr/bin/git gh ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /ref/tags/v9 --jq ode-gyp-bin/node--cached ache/go/1.25.8/x--name-only (http block)
  • https://api.github.com/repos/aws-actions/configure-aws-credentials/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/aws-actions/configure-aws-credentials/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv -unreachable=false /tmp/go-build2525330762/b200/vet.cfg /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet ath ../../../.prinfocmp (http block)
    • Triggering command: /usr/bin/gh gh api /repos/aws-actions/configure-aws-credentials/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv runs/20260512-185837-15142/test-148548065/.github/workflows security /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet url (http block)
    • Triggering command: /usr/bin/gh gh api /repos/aws-actions/configure-aws-credentials/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv ithub-script/git/ref/tags/v9 sh bject.type] | @tsv 5837-15142/test-/opt/hostedtoolcache/node/24.14.1/x64/bin/npm (http block)
  • https://api.github.com/repos/azure/login/git/ref/tags/v2
    • Triggering command: /usr/bin/gh gh api /repos/azure/login/git/ref/tags/v2 --jq [.object.sha, .object.type] | @tsv -t resolved$ (http block)
    • Triggering command: /usr/bin/gh gh api /repos/azure/login/git/ref/tags/v2 --jq [.object.sha, .object.type] | @tsv ithub-script/git/ref/tags/v8 ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet bject.type] | @tsv --write scripts/**/*.js ache/go/1.25.8/xinstall /usr/libexec/doc--package-lock-only dock�� ithub-script/git/ref/tags/v9 ache/go/1.25.8/x--jq 1/x64/bin/node --write ../../../**/*.jsmaintenance (http block)
    • Triggering command: /usr/bin/gh gh api /repos/azure/login/git/ref/tags/v2 --jq [.object.sha, .object.type] | @tsv 0123-32559/test-838321185 gh (http block)
  • https://api.github.com/repos/docker/login-action/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/docker/login-action/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv -t security (http block)
    • Triggering command: /usr/bin/gh gh api /repos/docker/login-action/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv ithub-script/git/ref/tags/v9 ache/go/1.25.8/x64/pkg/tool/linuremote.origin.url bject.type] | @tsv 5837-15142/test-/opt/hostedtoolcache/node/24.14.1/x64/bin/npm scripts/**/*.js ache/go/1.25.8/x--package-lock-only infocmp -1 ithub-script/git/ref/tags/v9 ache/go/1.25.8/x--jq 1/x64/bin/node --write ../../../**/*.jsadd (http block)
    • Triggering command: /usr/bin/gh gh api /repos/docker/login-action/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv licyTrustedUsersCompiledOutput1880417883/001 -parallel=4 /usr/bin/git url ./... -short git -C /tmp/gh-aw-test-runs/20260512-190123-32559/test-add-source-path-3536804838/.gith--detach config ache/node/24.14.1/x64/bin/node remote.upstream.git --jq /usr/bin/gh ache/node/24.14.1/x64/bin/node (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0.1.2
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq [.object.sha, .object.type] | @tsv Onlymin-integrity_only_defaults_repo2008898108/001 (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq [.object.sha, .object.type] | @tsv /ref/tags/v9 --jq r: $owner, name: $name) { hasDiscussionsEnabled } } edOutput14602779infocmp --others tartedAt,updatedxterm-color gh s /ref/tags/v9 --jq sv g_.a 5330762/b155/vetapi .cfg infocmp (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq [.object.sha, .object.type] | @tsv 0123-32559/test-3640250721 gh e/git /ref/tags/v9 --jq n-dir/node e/git /hom�� ry=1 **/*.cjs (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv -v .cfg ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /../../.prettier/tmp/go-build3219746521/b212/cli.test erignore (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv list --json (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv efaultBranchFromLsRemoteWithRealGitmain_branch95--repo efaultBranchFromLsRemoteWithRealGitmain_branch95owner/repo .cfg /ref/tags/v9 --jq sv node js/f�� /ref/tags/v9 gh 1/x64/bin/node /ref/tags/v9 --jq sv ache/go/1.25.8/x--jq (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv 10 on ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /../../.prettiersh erignore (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv xterm-color x_amd64/vet /usr/bin/infocmp g_.a credential.usernjs/fuzz_sanitize_label_harness.cjs 64/pkg/tool/linux_amd64/vet infocmp -1 ithub-script/git/ref/tags/v9 64/pkg/tool/linuorigin (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv ace-editor.md gh sv /ref/tags/v9 --jq ode-gyp-bin/node--get-regexp node js/f�� 0123-32559/test-65405536/.github/workflows gh ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile /ref/tags/v9 --jq sv ache/go/1.25.8/x-f (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-05-05 (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-04-12 (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-02-11 (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name .cfg 64/pkg/tool/linux_amd64/vet nore (http block)
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 .cfg 64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name wc fb2243f2f7244c53cc888e0f47e9c9db-d (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name .cfg 64/pkg/tool/linux_amd64/vet nore (http block)
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 .cfg 64/pkg/tool/linux_amd64/vet nore (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name --jq ache/node/24.14.1/x64/bin/node ithub-script/gitgit /opt/hostedtoolcremote bject.type] | @tremove gh _lab�� y_only_defaults_repo1306140836/001 --jq /usr/bin/gh ithub-script/gitgit bash bject.type] | @t--get gh (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1234567890
    • Triggering command: /usr/bin/gh gh api repos/{owner}/{repo}/actions/runs/1234567890 --jq {databaseId: .id, number: .run_number, url: .html_url, status: .status, conclusion: .conclusion, workflowName: .name, workflowPath: .path, createdAt: .created_at, startedAt: .run_started_at, updatedAt: .updated_at, event: .event, headBranch: .head_branch, (http block)
    • Triggering command: /usr/bin/gh gh api repos/{owner}/{repo}/actions/runs/1234567890 --jq {databaseId: .id, number: .run_number, url: .html_url, status: .status, conclusion: .conclusion, workflowName: .name, workflowPath: .path, createdAt: .created_at, startedAt: .run_started_at, updatedAt: .updated_at, event: .event, headBranch: .head_branch, h ../../../.pret.prettierignore --jq /usr/bin/infocmp --paginate repos/{owner}/{r/home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/.bin/pre�� /usr/bin/infocmp--write infocmp -1 w/js/**/*.json' --ignore-path infocmp /usr/bin/gh /ref/tags/v9 64/pkg/tool/linuinit sv gh (http block)
    • Triggering command: /usr/bin/gh gh api repos/{owner}/{repo}/actions/runs/1234567890 --jq {databaseId: .id, number: .run_number, url: .html_url, status: .status, conclusion: .conclusion, workflowName: .name, workflowPath: .path, createdAt: .created_at, startedAt: .run_started_at, updatedAt: .updated_at, event: .event, headBranch: .head_branch, h ../../../.prettierignore --jq (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name .cfg 64/pkg/tool/linux_amd64/vet nore (http block)
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 user.email 64/pkg/tool/linux_amd64/vet nore (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name mLsRemoteWithRealGitbranch_with_-w ache/node/24.14.1/x64/bin/node go test.go ext_fuzz_test.go--get _test.go z_te�� *.json' '!../../../pkg/workflow/js/**/*.json' ---p ing_test.go /usr/bin/infocmp /repos/actions/ggit --jq (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name .cfg 64/pkg/tool/linux_amd64/vet nore (http block)
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 .cfg 64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name --jq 1/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/node ithub-script/gitgit /tmp/gh-aw/aw-feremote 64/pkg/tool/linuremove gh tion�� ut3982466868/001 --jq nutil.test ignore gcc bject.type] | @tuser.name nutil.test (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name .cfg 64/pkg/tool/linux_amd64/vet nore (http block)
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 .cfg 64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name --jq tions/setup/node_modules/.bin/node ithub-script/gitgit /opt/hostedtoolcremote 64/pkg/tool/linuget-url gh tion�� 11/001/test-inlined-imports-enabremote.origin.url --jq son ignore /opt/hostedtoolcconfig bject.type] | @t--get gh (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name .cfg 64/pkg/tool/linux_amd64/vet nore (http block)
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 .cfg $name) { hasDiscussionsEnabled } } (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name basename tions/setup/js/node_modules/.bin/node (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name .cfg 64/pkg/tool/linux_amd64/vet nore (http block)
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 .cfg 64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name git tions/node_modules/.bin/node (http block)
  • https://api.github.com/repos/github/gh-aw/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path json' --ignore-path ../../../.pr**/*.json (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 (http block)
  • https://api.github.com/repos/github/gh-aw/contents/.github/workflows/shared/reporting.md
    • Triggering command: /tmp/go-build3219746521/b212/cli.test /tmp/go-build3219746521/b212/cli.test -test.testlogfile=/tmp/go-build3219746521/b212/testlog.txt -test.paniconexit0 -test.timeout=10m0s /tmp/go-build3219746521/b297/vet.cfg (http block)
    • Triggering command: /tmp/go-build1614441955/b405/cli.test /tmp/go-build1614441955/b405/cli.test -test.testlogfile=/tmp/go-build1614441955/b405/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true --get-regexp ^remote\..*\.gh-/home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/.bin/pre�� /usr/bin/infocmp--write infocmp -1 ath ../../../.pr**/*.json infocmp sv ithub-script/gitnode x_amd64/vet bject.type] | @tprettier infocmp (http block)
    • Triggering command: /tmp/go-build371157791/b405/cli.test /tmp/go-build371157791/b405/cli.test -test.testlogfile=/tmp/go-build371157791/b405/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true '**/*.ts' '**/*.sh --jq x_amd64/compile /usr/bin/git conf�� ithub-script/git/ref/tags/v9 ^remote\..*\.gh-resolved$ (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v0.47.4
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq [.object.sha, .object.type] | @tsv -unreachable=false /tmp/go-build3219746521/b237/vet.cfg repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq [.object.sha, .object.type] | @tsv ithub-script/git/ref/tags/v9 ortcfg 1/x64/bin/node CompiledOutput28tr om/aymanbagabas/\n ache/go/1.25.8/x: git ance�� ithub-script/git/ref/tags/v9 Update initial file 1/x64/bin/node -unreachable=falsh /tmp/go-build252-c 9746521/b233/vetecho 'not found' >&2; exit 1 infocmp (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq [.object.sha, .object.type] | @tsv 4441955/b468/types.test Test User ache/node/24.14.1/x64/bin/node /repos/actions/gtr --jq bin/node VWw7VJguVlRAx/jNQYSQDdMsvnnTZDby--jq t-81�� k/gh-aw/gh-aw/.github/workflows/archie.md k/gh-aw/gh-aw/pkg/stringutil/identifiers.go 4441955/b468/_pkg_.a ath ../../../.prsh nly layTitle node (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv /ref/tags/v9 origin sv */*.ts' '**/*.jsinfocmp --get x_amd64/vet git conf�� /ref/tags/v9.0.0 remote.origin.url sv 52/001 --local x_amd64/vet /usr/bin/git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv Gitcustom_branch1253959761/001' Gitcustom_branch1253959761/001' 1/x64/bin/node --detach ache/go/1.25.8/x-1 /usr/bin/infocmpxterm-color gh js tmatter-with-nested-objects.md --jq x_amd64/compile ithub-script/gitgit node bject.type] | @tsv x_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv ../pkg/workflow/-errorsas (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv ithub-script/git--exclude-hidden=receive --jq 1/x64/bin/node /ref/tags/v9 nly sv git ode_�� phen504837149/001 phen504837149/002/work 1/x64/bin/node /ref/tags/v9 --jq sv infocmp (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv iant-3893760633/.github/workflows 64/pkg/tool/linu^remote\..*\.gh-resolved$ sh ser.test infocmp 64/pkg/tool/linu/home/REDACTED/work/gh-aw/gh-aw/.github/workflows/approach-validator.md infocmp -1 th .prettierignore --log-level=e!../../../pkg/workflow/js/**/*.json 64/pkg/tool/linu--jq bject.type] | @tsv g_.a on g_.a infocmp (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v2.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv ../pkg/workflow/-errorsas (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv ithub-script/gitgo1.25.8 --jq 1/x64/bin/node /ref/tags/v9 nly sv git ance�� ithub-script/git/ref/tags/v9 gh 1/x64/bin/node /ref/tags/v9 --jq sv infocmp (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv /ref/tags/v9 infocmp 1/x64/bin/node ithub-script/gitgit 64/pkg/tool/linu-C bject.type] | @t/tmp/gh-aw-test-runs/20260512-190123-32559/test-4218621315/.github/workflows sed s/-\�� th .prettierignoremote.origin.url infocmp 1/x64/bin/node xterm-color ache/go/1.25.8/x-C /usr/bin/infocmp/tmp/compile-all-instructions-test-201529098/.github/workflows gh (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v3.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv ../pkg/workflow/-errorsas (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv iant-1356023865/.github/workflows --jq 1/x64/bin/node /ref/tags/v9 nly sv git phen�� ithub-script/git/ref/tags/v9 712b0468b7a707aa024235661eaeb59d--ignore-path 1/x64/bin/node /ref/tags/v9 --jq sv infocmp (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv json' --ignore-path ../../../.pr**/*.json --jq sv 0123-32559/test-git gh ache/go/1.25.8/x/tmp/gh-aw-test-runs/20260512-190238-41941/test-3945645986/.github/workflows infocmp -1 th .prettierignoremote.origin.url ache/go/1.25.8/x64/pkg/tool/linu--ignore-path _modules/.bin/node 838321185 gh 4441955/b481=> /opt/hostedtoolc--jq (http block)
  • https://api.github.com/repos/google-github-actions/auth/git/ref/tags/v2
    • Triggering command: /usr/bin/gh gh api /repos/google-github-actions/auth/git/ref/tags/v2 --jq [.object.sha, .object.type] | @tsv -unreachable=false /tmp/go-build2525330762/b209/vet.cfg /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet ath ../../../.prnode (http block)
    • Triggering command: /usr/bin/gh gh api /repos/google-github-actions/auth/git/ref/tags/v2 --jq [.object.sha, .object.type] | @tsv ithub-script/git/ref/tags/v9 sh bject.type] | @tsv 5837-15142/test-node (http block)
    • Triggering command: /usr/bin/gh gh api /repos/google-github-actions/auth/git/ref/tags/v2 --jq [.object.sha, .object.type] | @tsv 0123-32559/test-838321185 ../../../**/*.json (http block)
  • https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq [.object.sha, .object.type] | @tsv successfully" (http block)
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq [.object.sha, .object.type] | @tsv /ref/tags/v9 origin sv */*.ts' '**/*.jsinfocmp --local x_amd64/vet git init�� /ref/tags/v9 x_amd64/vet sv url --local DiscussionsEnabled } } gh (http block)
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq [.object.sha, .object.type] | @tsv /tmp/gh-aw infocmp 1/x64/bin/node xterm-color ache/go/1.25.8/x-o /usr/bin/infocmp/tmp/go-build1614441955/b465/tty.test gh js ../pkg/workflow/-s --jq 64/bin/go ns/configure-awsgh sh bject.type] | @t/repos/github/gh-aw/git/ref/tags/v2.0.0 gh (http block)
  • https://api.github.com/repos/nonexistent/repo/actions/runs/12345
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion (http block)
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion son e/git bject.type] | @tsv 64/pkg/tool/linux_amd64/vet api thub/workflows --jq x_amd64/vet nore /opt/hostedtoolcapi ache/node/24.14./repos/actions/github-script/git/ref/tags/v9 x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion -bool -buildtags ache/node/24.14.xterm-color 64/pkg/tool/linux_amd64/vet -1 ithub-script/git/ref/tags/v9 /usr/lib/git-core/git k/node_modules/.bin/sh nore --revs ache/node/24.14.xterm-color infocmp (http block)
  • https://api.github.com/repos/owner/repo/actions/secrets
    • Triggering command: /usr/bin/gh gh api /repos/owner/repo/actions/secrets --jq .secrets[].name json' --ignore-path ../../../.pr**/*.json (http block)
    • Triggering command: /usr/bin/gh gh api /repos/owner/repo/actions/secrets --jq .secrets[].name /ref/tags/v8 infocmp sv ithub-script/gitprettier x_amd64/vet bject.type] | @t../../../**/*.json gh api /ref/tags/v9 --jq sv ithub-script/gitgit remote.origin.ur-C bject.type] | @t/home/REDACTED/work/gh-aw/gh-aw infocmp (http block)
    • Triggering command: /usr/bin/gh gh api /repos/owner/repo/actions/secrets --jq .secrets[].name ath ../../../.pr--ignore-path infocmp (http block)
  • https://api.github.com/repos/owner/repo/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo developer-action-main/dist/gh-gp../../../.prettierignore hub.com/.extrahe/opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo odules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/node hub.com/.extrahe/opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh workflow list --repo owner/repo --json name,path,state 64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/test-owner/test-repo/actions/secrets
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name json' --ignore-path ../../../.pr**/*.json (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name -c=4 -nolocalimports -importcfg /tmp/go-build1614441955/b432/importcfg -pack /home/REDACTED/work/gh-aw/gh-aw/pkg/logger/doc.go /home/REDACTED/work/gh-aw/gh-aw/pkg/logger/logger.go api w/js/**/*.json' --ignore-path --jq x_amd64/cgo ithub-script/gitinfocmp remote bject.type] | @txterm-color x_amd64/cgo (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name ch ylQP4Z8/vCNYLdc7Add workflow bject.type] | @tsv 2862689289/.githsh --jq x_amd64/vet gh --ve�� ithub-script/git/ref/tags/v9 x_amd64/vet ker/cli-plugins/docker-buildx g_.a --jq ache/uv/0.11.14//tmp/gh-aw-test-runs/20260512-190238-41941/test-source-field-variant-3893760633/.github/workflows ker/cli-plugins/remote (http block)
  • https://api.github.com/repos/test/repo
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch edOutput1460277930/001 --others tartedAt,updatedAt,event,headBranch,headSha,displayTitle rkflow/js/**/*.jgh (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch xterm-color /bin/sh (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue May 12, 2026 that may be closed by this pull request
11 tasks
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/a6d1f4bf-b3b4-4470-8a5b-fb530495a900

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot AI changed the title [WIP] Rename functions in pkg/sliceutil for clarity Rename MapToSliceMapKeys in pkg/sliceutil May 12, 2026
Copilot AI requested a review from gh-aw-bot May 12, 2026 19:06
@pelikhan pelikhan marked this pull request as ready for review May 12, 2026 19:12
Copilot AI review requested due to automatic review settings May 12, 2026 19:12
@pelikhan pelikhan merged commit 0d6194a into main May 12, 2026
@pelikhan pelikhan deleted the copilot/function-rename-pkg-sliceutil branch May 12, 2026 19:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the exported sliceutil.MapToSlice helper to sliceutil.MapKeys to better reflect behavior (returns map keys) and align with Go stdlib naming conventions (maps.Keys).

Changes:

  • Renamed MapToSliceMapKeys in pkg/sliceutil, including doc comment updates.
  • Updated README/spec tests and unit tests to reflect the new API.
  • Updated call sites across pkg/cli and pkg/workflow to use MapKeys.
Show a summary per file
File Description
pkg/sliceutil/sliceutil.go Renames exported helper to MapKeys
pkg/sliceutil/README.md Updates documented public API table
pkg/sliceutil/sliceutil_test.go Renames unit test and updates assertions/messages
pkg/sliceutil/spec_test.go Renames public API spec test and updates call sites/messages
pkg/workflow/yaml_env_helpers.go Updates header key extraction call site
pkg/workflow/mcp_setup_generator.go Updates several MCP map-key extraction call sites
pkg/workflow/mcp_config_custom.go Updates env/header key extraction call sites
pkg/cli/run_push.go Updates file-map key extraction call site
pkg/cli/gateway_logs_render.go Updates tool/server key extraction call sites
pkg/cli/firewall_log.go Updates domain-set key extraction call sites
pkg/cli/audit_report_render_guard.go Updates blocked-tool key extraction call site

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 11/11 changed files
  • Comments generated: 1

Comment on lines +30 to 34
// MapKeys converts a map's keys to a slice.
// The order of elements is not guaranteed as map iteration order is undefined.
// This is a pure function that does not modify the input map.
func MapToSlice[K comparable, V any](m map[K]V) []K {
func MapKeys[K comparable, V any](m map[K]V) []K {
result := make([]K, 0, len(m))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[function-namer] Go function rename plan: pkg/sliceutil

4 participants