Skip to content

Add centralized slash-command trigger strategy with compiler-generated agentic_commands router workflow#31605

Merged
pelikhan merged 43 commits into
mainfrom
copilot/update-compiler-slash-commands
May 12, 2026
Merged

Add centralized slash-command trigger strategy with compiler-generated agentic_commands router workflow#31605
pelikhan merged 43 commits into
mainfrom
copilot/update-compiler-slash-commands

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 12, 2026

  • Review new PR comment and determine required action (merge main and recompile)
  • Run baseline targeted tests before applying new changes
  • Unshallow repository, fetch origin/main, and merge into current branch
  • Recompile workflows and review generated diffs
  • Run targeted validation tests/lint for changed areas
  • Run parallel validation and reply to the PR comment with commit hash

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Add centralized slash command trigger strategy support Add centralized slash-command trigger strategy with compiler-generated router workflow May 12, 2026
Copilot AI requested a review from pelikhan May 12, 2026 00:12
@pelikhan
Copy link
Copy Markdown
Collaborator

@copilot make /cloclo and /archie centralized

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 12, 2026

@copilot make /cloclo and /archie centralized

Done in 03ea49e — both /cloclo and /archie are now configured with on.slash_command.strategy: centralized, and their lock workflows were recompiled.

Copy link
Copy Markdown
Collaborator

@pelikhan pelikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot the compiler must also generate the github actions that declares the events and does the workflow_dispatch. Call it "agentic_slash_commands.yml"

Copilot AI and others added 2 commits May 12, 2026 01:57
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Copy link
Copy Markdown
Collaborator

@copilot remove legacy trigger file

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 12, 2026

@copilot the compiler must also generate the github actions that declares the events and does the workflow_dispatch. Call it "agentic_slash_commands.yml"

Implemented in 6f97404. The compiler now targets agentic_slash_commands.yml for centralized slash routing, and the generated workflow declares merged events and dispatches matching .lock.yml workflows via workflow_dispatch.

Copilot AI changed the title Add centralized slash-command trigger strategy with compiler-generated router workflow Add centralized slash-command trigger strategy with compiler-generated agentic_slash_commands router workflow May 12, 2026
Copilot AI requested a review from pelikhan May 12, 2026 02:06
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 12, 2026

@copilot remove legacy trigger file

Done in 2f2666b — removed legacy trigger-file handling and tests tied to agentics-slash-command-trigger.yml.

Comment on lines +39 to +41
permissions:
actions: write
contents: read
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot empty permission at the top level and specific permissions in each job

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 0776395 — set top-level permissions: {} and moved explicit permissions to the route job.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 12, 2026

@copilot move compiler version header comment as the first line comment and a serialized JSON payload. Similar schema to gh-aw-metadata, but call it

gh-aw-commands: {...

Done in 8742d99 (plus test follow-up in 7165207). agentic_commands.yml now emits first-line metadata as serialized JSON using # gh-aw-commands: {...} with compiler version data.

@pelikhan
Copy link
Copy Markdown
Collaborator

@copilot include list of commands and workflows in the gh-aw-commands payload header. Add a version for the payload header format

Copilot AI and others added 2 commits May 12, 2026 17:34
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

Hey @app/copilot-swe-agent 👋 — great work on the centralized slash-command routing feature! The PR is well-structured, includes tests across multiple packages, and comes with an ADR document — that's a solid contribution.

However, this repository doesn't have a CONTRIBUTING.md, so it's not possible to formally evaluate this PR against contribution guidelines. Maintainers may want to consider adding one to help guide future contributors.

The PR looks technically thorough — 1836 lines changed across Go implementation, JS actions, lock files, docs, and tests — and appears focused on a single coherent feature. No new external dependencies were added. This looks ready for maintainer review on technical merit.

Generated by Contribution Check · ● 6.4M ·

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Copy link
Copy Markdown
Collaborator

@copilot centralize all other slash_commands expect for Q and scout

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 12, 2026

@copilot include list of commands and workflows in the gh-aw-commands payload header. Add a version for the payload header format

Implemented in 31a6d32.

agentic_commands.yml now emits # gh-aw-commands with a payload-format version (payload_version) and explicit sorted commands and workflows lists, with compiler tests updated accordingly.

@copilot centralize all other slash_commands expect for Q and scout

Implemented in 31a6d32.

All slash-command workflows are now centralized except /q and /scout, and workflows were recompiled so agentic_commands.yml and affected lockfiles reflect the updated routing set.

Comment on lines +49 to +51
- name: Checkout repository
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot in dev mode, you still need to insert the ./actions/setup step to copy the runtime file. See how this is done with the agentic_maintenance code and reuse helper to configure the runtime files.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented in f1eb19f.

agentic_commands.yml generation now adds Setup Scripts (using ./actions/setup in dev mode via ResolveSetupActionReference) and routes load runtime files from ${{ runner.temp }}/gh-aw/actions, matching the maintenance runtime setup pattern.

Copilot AI and others added 2 commits May 12, 2026 18:19
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI requested a review from pelikhan May 12, 2026 18:27
@pelikhan
Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request

…er-slash-commands

# Conflicts:
#	.github/workflows/grumpy-reviewer.lock.yml

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 12, 2026

@copilot resolve the merge conflicts in this pull request

Resolved in 80cec81 — merged origin/main into this branch and fixed the merge conflict in .github/workflows/grumpy-reviewer.lock.yml.

@pelikhan pelikhan merged commit e7063a4 into main May 12, 2026
@pelikhan pelikhan deleted the copilot/update-compiler-slash-commands branch May 12, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants