fix: convert double quotes to single quotes in experiment comparison expressions

[Copilot]

Bug Fix

What was the bug?

GitHub Actions ${{ }} expressions only support single-quoted string literals. The compiler's transformExperimentsExpression was passing double quotes through verbatim when rewriting experiments.<name> == "value" to steps.pick-experiment.outputs.<name> == "value", producing expressions rejected at workflow parse time.

How did you fix it?

• pkg/workflow/expression_extraction.go: transformExperimentsExpression now replaces " → ' in the comparison remainder. Updated experimentComparisonRegex to also accept single-quoted input (making re-compilation idempotent).

// Before
return "steps.pick-experiment.outputs." + m[1] + m[2]
// ${{ steps.pick-experiment.outputs.reasoning_depth == "multi_candidate" }}  ❌

// After
remainder := strings.ReplaceAll(m[2], `"`, `'`)
return "steps.pick-experiment.outputs." + m[1] + remainder
// ${{ steps.pick-experiment.outputs.reasoning_depth == 'multi_candidate' }}  ✅

• pkg/workflow/expression_extraction_test.go: Updated four existing assertions to expect single-quoted output; added a test case for single-quoted input.

• .github/workflows/daily-fact.lock.yml: Recompiled — three "multi_candidate" occurrences are now 'multi_candidate' (env var key changed GH_AW_EXPR_DD64DF46 → GH_AW_EXPR_CBA23170).

[pelikhan]

@copilot the compiler should also complain about using single quotes in expressions so that the agent fixes it

[Copilot]

Pull request overview

Fixes GitHub Actions expression compilation for experiments.<name> == <string> by ensuring generated ${{ }} expressions use single-quoted string literals (and accepting single-quoted input to keep recompilation idempotent).

Changes:

• Updated experimentComparisonRegex and transformExperimentsExpression to normalize comparison string literals to single quotes.
• Adjusted unit tests to expect single-quoted output and added coverage for single-quoted input.
• Recompiled daily-fact.lock.yml to reflect updated expression hashing/output (including updated placeholder/env-var names).

Show a summary per file

File	Description
pkg/workflow/expression_extraction.go	Updates experiment-comparison detection/rewriting and normalizes quotes for Actions expression compatibility.
pkg/workflow/expression_extraction_test.go	Updates expectations for rewritten expressions and adds a single-quoted input test case.
.github/workflows/daily-fact.lock.yml	Recompiled workflow lock output reflecting the quote normalization and resulting hash-based env var rename.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 3/3 changed files
• Comments generated: 2

[pelikhan]

@copilot review all comments

[Copilot]

@copilot the compiler should also complain about using single quotes in expressions so that the agent fixes it

Done. The compiler now emits a warning when experiment comparison expressions in the source markdown use double-quoted string literals (e.g. {{#if experiments.mode == "detail"}}), pointing authors to use single quotes instead. The warning is surfaced via detectDoubleQuotedExperimentComparisons in template_validation.go and wired into compiler_orchestrator_frontmatter.go.

I also fixed daily-fact.md to use single quotes at the source so the warning no longer fires on that file.