fix: ensure created_after_date is formatted string before date comparison #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeridth
force-pushed
the
jm-date-issue-fix
branch
from
566371f
to
3bba07b
Compare
…ison Fixes #92 Stop validating created_after_date as just a 10 character string and regex validate it as YYYY-DD-MM (where each is a digit in the string) - [x] add tests to specifically cover case with string is 2020-01-01 Signed-off-by: jmeridth <[email protected]>
jmeridth
force-pushed
the
jm-date-issue-fix
branch
from
3bba07b
to
d4fbd29
Compare
jmeridth
changed the title
jmeridth
added
bug
zkoppert
approved these changes
Apr 11, 2024
add created_after_date content to error message Signed-off-by: jmeridth <[email protected]> Co-authored-by: Zack Koppert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92
Pull Request
Proposed Changes
Stop validating created_after_date as just a 10 character string and
regex validate it as YYYY-DD-MM (where each is a digit in the string)
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingReviewer
bug,documentation,enhancement,infrastructure, orbreaking