Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add configuration option for dependabot labels #238

Merged
merged 6 commits into from
Oct 4, 2024
Merged

feat: Add configuration option for dependabot labels #238

merged 6 commits into from
Oct 4, 2024

Conversation

jmrt47
Copy link
Contributor

@jmrt47 jmrt47 commented Oct 2, 2024 •
edited by zkoppert
Loading

Pull Request

Proposed Changes

Added an option to configure a list of labels been set to the dependabot configuration when a new configuration for a package manager is created.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

zkoppert
zkoppert reviewed Oct 3, 2024
View reviewed changes
test_dependabot_file.py Outdated Show resolved Hide resolved
zkoppert
zkoppert approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up! Looks great! I appreciate the thorough implementation and testing. 🎉

@zkoppert zkoppert merged commit 5fc56b2 into github:main Oct 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert zkoppert approved these changes

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@sutterj sutterj Awaiting requested review from sutterj sutterj is a code owner

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmrt47 @zkoppert @Jonas-Martin