Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: release when a new feature hits main #145

Merged
merged 1 commit into from
May 28, 2024
Merged

ci: release when a new feature hits main #145

merged 1 commit into from
May 28, 2024

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented May 26, 2024

Pull Request

Proposed Changes

Since enhancements are getting put in under the feat: prefix, let's change this to release on new feature.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

@zkoppert zkoppert requested a review from jmeridth as a code owner May 26, 2024 06:36
@zkoppert zkoppert changed the title release when a new feature hits main ci: release when a new feature hits main May 26, 2024
@zkoppert
Copy link
Member Author

If approved, we may wan to make this change in all other OSPO actions repos.

@jmeridth jmeridth changed the title ci: release when a new feature hits main chore: release when a new feature hits main May 26, 2024
@jmeridth jmeridth changed the title chore: release when a new feature hits main ci: release when a new feature hits main May 26, 2024
@jmeridth
Copy link
Member

jmeridth commented May 26, 2024

While we are in this file do we want to remove pull_request and just leave pull_request_target? To prevent double releases? And I agree, this change needs to go to all actions. will be separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants