Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pull_request_target for releases #137

Merged
merged 1 commit into from
May 21, 2024

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented May 21, 2024

Pull Request

Proposed Changes

  • add pull_request_target to release GitHub Action so we have access to fork PR labels

I am not worried about the security implications with us checking out the forked pull requests code. This action only fires after a merge to main so this means the pull request code has been reviewed by a maintainer. We are post-CI/code run.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

- [x] add pull_request_target to release GitHub Action so we have access to fork PR labels

I am not worried about the security implications with us checking out the forked pull requests code. This action only fires after a merge to main so this means the pull request code has been reviewed by a maintainer. We are post-CI/code run.

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth self-assigned this May 21, 2024
@jmeridth jmeridth requested a review from zkoppert as a code owner May 21, 2024 16:23
@jmeridth jmeridth merged commit ef1109f into main May 21, 2024
28 checks passed
@jmeridth jmeridth deleted the jm_add_pull_request_target_to_release_action branch May 21, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant