test: cover python get_last_session_id none case#825
Closed
haosenwang1018 wants to merge 1 commit intogithub:mainfrom
Closed
test: cover python get_last_session_id none case#825haosenwang1018 wants to merge 1 commit intogithub:mainfrom
haosenwang1018 wants to merge 1 commit intogithub:mainfrom
Conversation
Contributor
|
Thanks @haosenwang1018 for submitting all these PRs with test coverage. As it stands these are not something we would merge because:
If you're interested in working with us on test coverage that's wonderful and I'd be happy to discuss more. I'd recommend not submitting large numbers of PRs without coordination though as we are really focused on keeping the project moving and we won't necessarily have capacity to review and merge things that are not on our roadmap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_last_session_id()when the server returns no session idsession.getLastIdNonefor the no-session caseWhy
The happy path for
get_last_session_id()is now covered, but the default/no-session path was still untested. This PR locks down that behavior so regressions in payload shape orNonehandling are caught in CI.Validation
python -m pytest -q python/test_client.py -k 'get_last_session_id_returns_none_when_absent'git diff --check