Skip to content

Fix to_timedelta_int comment to accurately describe banker's rounding #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+6 −4
Closed

Fix to_timedelta_int comment to accurately describe banker's rounding #1676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbdb2a7
Initial plan
Copilot Jun 15, 2026
036eaf4
Update to_timedelta_int comment to note banker's rounding, use round()
Copilot Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions python/copilot/generated/session_events.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions scripts/codegen/python.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2538,8 +2538,9 @@ export function generatePythonSessionEventsCode(schema: JSONSchema7): string {
out.push(`def to_timedelta_int(x: timedelta) -> int:`);
out.push(` assert isinstance(x, timedelta)`);
out.push(` milliseconds = x.total_seconds() * 1000.0`);
out.push(` assert milliseconds.is_integer()`);
out.push(` return int(milliseconds)`);
out.push(` # Durations can carry sub-millisecond precision; round to the nearest whole ms`);
out.push(` # using Python's default banker's rounding (round-half-to-even).`);
out.push(` return round(milliseconds)`);
out.push(``);
out.push(``);
}
Expand Down