Skip to content

Rust [EXPERIMENT]: Reintroduce extractor resolution #20753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Rust [EXPERIMENT]: Reintroduce extractor resolution #20753

wants to merge 3 commits into from
+1,327 −558

Conversation

@hvitved
Copy link
Contributor

@hvitved hvitved commented Nov 4, 2025 •
edited
Loading

Partially reverts #20295.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Nov 4, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 4, 2025
View reviewed changes
rust/ql/lib/codeql/rust/elements.qll Outdated

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.MethodCallExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PathAstNode
Loading
.
rust/ql/lib/codeql/rust/elements/Resolvable.qll
Comment on lines +9 to +11
/**
* One of `PathExpr`, `RecordExpr`, `PathPat`, `RecordPat`, `TupleStructPat` or `MethodCallExpr`.
*/

Check warning

Code scanning / CodeQL

Class QLDoc style. Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.
rust/ql/lib/codeql/rust/elements/internal/ResolvableImpl.qll
Comment on lines +15 to +17
/**
* One of `PathExpr`, `RecordExpr`, `PathPat`, `RecordPat`, `TupleStructPat` or `MethodCallExpr`.
*/

Check warning

Code scanning / CodeQL

Class QLDoc style. Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.
rust/ql/test/extractor-tests/generated/MethodCallExpr/MethodCallExpr.ql
toBeTested(x) and not x.isUnknown() and getArg = x.getArg(index)
}

query predicate getResolvedPath(MethodCallExpr x, string getResolvedPath) {

Check warning

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning generated test

This predicate starts with 'get' but does not return a value.
rust/ql/test/extractor-tests/generated/MethodCallExpr/MethodCallExpr.ql
toBeTested(x) and not x.isUnknown() and getResolvedPath = x.getResolvedPath()
}

query predicate getResolvedCrateOrigin(MethodCallExpr x, string getResolvedCrateOrigin) {

Check warning

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning generated test

This predicate starts with 'get' but does not return a value.
rust/ql/test/extractor-tests/generated/StructExpr/StructExpr.ql
toBeTested(x) and not x.isUnknown() and getResolvedPath = x.getResolvedPath()
}

query predicate getResolvedCrateOrigin(StructExpr x, string getResolvedCrateOrigin) {

Check warning

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning generated test

This predicate starts with 'get' but does not return a value.
rust/ql/test/extractor-tests/generated/StructPat/StructPat.ql

query predicate instances(StructPat x) { toBeTested(x) and not x.isUnknown() }

query predicate getResolvedPath(StructPat x, string getResolvedPath) {

Check warning

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning generated test

This predicate starts with 'get' but does not return a value.
rust/ql/test/extractor-tests/generated/StructPat/StructPat.ql
toBeTested(x) and not x.isUnknown() and getResolvedPath = x.getResolvedPath()
}

query predicate getResolvedCrateOrigin(StructPat x, string getResolvedCrateOrigin) {

Check warning

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning generated test

This predicate starts with 'get' but does not return a value.
rust/ql/test/extractor-tests/generated/TupleStructPat/TupleStructPat.ql

query predicate instances(TupleStructPat x) { toBeTested(x) and not x.isUnknown() }

query predicate getResolvedPath(TupleStructPat x, string getResolvedPath) {

Check warning

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning generated test

This predicate starts with 'get' but does not return a value.
rust/ql/test/extractor-tests/generated/TupleStructPat/TupleStructPat.ql
toBeTested(x) and not x.isUnknown() and getResolvedPath = x.getResolvedPath()
}

query predicate getResolvedCrateOrigin(TupleStructPat x, string getResolvedCrateOrigin) {

Check warning

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning generated test

This predicate starts with 'get' but does not return a value.
@hvitved hvitved force-pushed the rust/extractor-resolution-experiment branch from c642695 to ec8d5f0 Compare November 4, 2025 11:10
@hvitved hvitved force-pushed the rust/extractor-resolution-experiment branch from ec8d5f0 to d184eb4 Compare November 4, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Rust Pull requests that update Rust code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hvitved