Skip to content

Rust: add test cases for basic unwrapping and pattern matching #20003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Jul 9, 2025

No description provided.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Jul 9, 2025
geoffw0
geoffw0 previously approved these changes Jul 10, 2025
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me. A lot of simple cases type inference needs to cover.

@aibaars aibaars force-pushed the aibaars/query-result branch from ad136ca to cc5e6b2 Compare July 10, 2025 09:15
@aibaars aibaars marked this pull request as ready for review July 10, 2025 09:15
@aibaars aibaars requested a review from a team as a code owner July 10, 2025 09:15
@aibaars
Copy link
Contributor Author

aibaars commented Jul 10, 2025

@geoffw0 Could you approve the PR again? There was a conflict. I also remove my line that tested a pattern match on a tuple. You already covered tuples more extensively .

Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aibaars aibaars merged commit b573246 into main Jul 10, 2025
15 checks passed
@aibaars aibaars deleted the aibaars/query-result branch July 10, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants