JS: Mass promotion of queries to quality status
#19776
Open
+428
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Napalys
force-pushed
the
js/mass_quality_promotion
branch
from
7686f1f to
69734a8
Compare
Napalys
force-pushed
the
js/mass_quality_promotion
branch
from
69734a8 to
0c31838
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR promotes various JavaScript CodeQL queries to quality status by adding the @tags quality annotation and updating related tags, and updates the integration-tests suite to include all newly promoted queries.
- Bulk update: Added
@tags qualityand refined tag lists in Declarations, DOM, AngularJS, and other query modules. - Test suite update: Extended
javascript-code-quality.qls.expectedto cover all newly promoted queries.
Reviewed Changes
Copilot reviewed 96 out of 96 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| javascript/ql/src/Declarations/* | Added @tags quality and adjusted tags on declaration queries |
| javascript/ql/src/DOM/* | Added @tags quality and refined tags on DOM queries |
| javascript/ql/src/AngularJS/* | Added @tags quality and refined tags on AngularJS queries |
| javascript/ql/integration-tests/query-suite/javascript-code-quality.qls.expected | Updated expected suite list to include all promoted queries |
Comments suppressed due to low confidence (1)
javascript/ql/src/DOM/PseudoEval.ql:11
- The CWE identifier was changed from
cwe-676tocwe-67, which appears incorrect. Please restore the correct identifier (e.g.,external/cwe/cwe-676).
* external/cwe/cwe-67
owen-mc
reviewed
Jun 19, 2025
owen-mc
reviewed
Jun 19, 2025
javascript/ql/src/Expressions/WhitespaceContradictsPrecedence.ql
Outdated
Show resolved
Hide resolved
javascript/ql/src/Statements/SuspiciousUnusedLoopIterationVariable.ql
Outdated
Show resolved
Hide resolved
Thank you for the helpful feedback! 🙇 |
owen-mc
previously approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR promotes multiple JavaScript queries by adding quality-related tags, clearly indicating their promotion to quality status.
Notes for reviewers:
js/loop-iteration-skipped-due-to-shiftingbecause it is currently being promoted in another pr JS: Promotejs/loop-iteration-skipped-due-to-shiftingto the Code Quality suite #19743