Skip to content

Improve TypeORM model #19762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

Conversation

Vasco-jofra
Copy link
Contributor

Improve the TypeORM model with the Repository API https://orkhan.gitbook.io/typeorm/docs/repository-api, which includes the .query(sink) SQL injection sink.

@Vasco-jofra Vasco-jofra requested a review from a team as a code owner June 13, 2025 13:39
@github-actions github-actions bot added the JS label Jun 13, 2025
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will merge if evaluation looks good.

@asgerf asgerf added the no-change-note-required This PR does not need a change note label Jun 25, 2025
@asgerf
Copy link
Contributor

asgerf commented Jun 25, 2025

A CI check is failing due to not begin autoformatted.

@Vasco-jofra
Copy link
Contributor Author

@asgerf Formatting updated! Sorry about that

What would be the process of moving this "experimental" model of the TypeORM library to the standard library? I'm currently having to create a custom CodeQL bundle that imports it to be able to use it with the default SQL injection query

@asgerf
Copy link
Contributor

asgerf commented Jun 26, 2025

What would be the process of moving this "experimental" model of the TypeORM library to the standard library? I'm currently having to create a custom CodeQL bundle that imports it to be able to use it with the default SQL injection query

I'll see if we can move it out after merging this PR.

@asgerf asgerf merged commit 3247bab into github:main Jun 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JS no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants