Skip to content

JS: Mark AngularJS $location as client-side remote flow source #19587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgerf merged 1 commit into from
Jun 3, 2025
Merged

JS: Mark AngularJS $location as client-side remote flow source #19587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions javascript/ql/lib/semmle/javascript/frameworks/AngularJS/AngularJSCore.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,20 +550,25 @@ class DirectiveTargetName extends string {
*
* See https://docs.angularjs.org/api/ng/service/$location for details.
*/
private class LocationFlowSource extends RemoteFlowSource instanceof DataFlow::MethodCallNode {
private class LocationFlowSource extends ClientSideRemoteFlowSource instanceof DataFlow::MethodCallNode
{
private ClientSideRemoteFlowKind kind;
Copy link

Copilot AI Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kind field is never assigned, so calls to kind.isQuery() or kind.isFragment() will fail. Assign kind = ClientSideRemoteFlowKind.Query when m == "search" and kind = ClientSideRemoteFlowKind.Fragment when m == "hash`.

Copilot uses AI. Check for mistakes.

LocationFlowSource() {
exists(ServiceReference service, string m, int n |
service.getName() = "$location" and
this = service.getAMethodCall(m) and
n = super.getNumArgument()
|
m = "search" and n < 2
m = "search" and n < 2 and kind.isQuery()
or
m = "hash" and n = 0
m = "hash" and n = 0 and kind.isFragment()
)
}

override string getSourceType() { result = "$location" }

override ClientSideRemoteFlowKind getKind() { result = kind }
}

/**
Expand Down