-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Go: Support 1.24 #18306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Go: Support 1.24 #18306
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
52e15f8
Go: Use `1.24rc1` in CI
mbg 595e68c
Go: Bump `go_sdk` to `1.24rc1` in `MODULE.bazel`
mbg 7623e2b
Go: Bump extractor to `go1.24rc1`
mbg f6b460b
Go: Set `maxGoVersion` to `1.24`
mbg e93c422
Go: Update test expectations for Go 1.24
mbg b829792
Revert some test expectations changes
owen-mc e3d6480
Add go.mod to Types tests
owen-mc d97cda7
Add test for aliases with type params, added in go 1.24
owen-mc b8cad66
Update test results
owen-mc cc459cd
Update toolchain version regex
owen-mc b328d15
Update to rc2
owen-mc 8c3aa93
Update test expectations for rc2
owen-mc 228983f
Update to rc3
owen-mc 1e74b7a
Update to 1.24.0
owen-mc 7c83b0e
Move comment and clarify
owen-mc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
119 changes: 60 additions & 59 deletions
119
go/ql/test/library-tests/semmle/go/Types/Field_getPackage.expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,59 +1,60 @@ | ||
| aliases.go:6:26:6:26 | x | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| aliases.go:8:26:8:26 | x | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| aliases.go:19:17:19:17 | x | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| cyclic.go:4:3:4:3 | s | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| cyclic.go:8:3:8:3 | u | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| cyclic.go:9:2:9:2 | f | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| cyclic.go:13:2:13:2 | t | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| cyclic.go:17:2:17:2 | s | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| depth.go:6:2:6:2 | b | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| depth.go:7:2:7:2 | c | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| depth.go:11:2:11:2 | f | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| depth.go:15:2:15:2 | d | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| depth.go:19:2:19:2 | f | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| embedded.go:4:2:4:2 | A | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| embedded.go:8:3:8:5 | Baz | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| embedded.go:12:2:12:4 | Qux | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| embedded.go:13:2:13:4 | Baz | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| generic.go:4:2:4:11 | valueField | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| generic.go:5:2:5:13 | pointerField | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| generic.go:6:2:6:11 | arrayField | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| generic.go:7:2:7:11 | sliceField | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| generic.go:8:2:8:9 | mapField | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| generic.go:12:2:12:13 | pointerField | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| generic.go:16:2:16:5 | root | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| generic.go:20:2:20:12 | structField | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| generic.go:21:2:21:9 | mapField | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| generic.go:25:2:25:12 | structField | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| generic.go:29:2:29:13 | pointerField | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| main.go:18:7:18:15 | NameClash | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| pkg1/embedding.go:19:23:19:26 | base | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/embedding.go:22:27:22:30 | base | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/embedding.go:25:24:25:31 | embedder | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/embedding.go:28:24:28:31 | embedder | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/embedding.go:36:2:36:5 | base | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/embedding.go:37:2:37:2 | f | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/promotedStructs.go:5:2:5:7 | SField | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/promotedStructs.go:14:2:14:7 | PField | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/promotedStructs.go:22:22:22:22 | S | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/promotedStructs.go:25:22:25:22 | P | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/tst.go:6:2:6:2 | f | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/tst.go:7:2:7:4 | Foo | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/tst.go:8:2:8:4 | Bar | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/tst.go:12:2:12:4 | Foo | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/tst.go:13:2:13:4 | Bar | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/tst.go:17:3:17:5 | Foo | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/tst.go:18:3:18:5 | Bar | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/tst.go:22:3:22:5 | Foo | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/tst.go:23:2:23:4 | Bar | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/tst.go:27:2:27:4 | val | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/tst.go:28:2:28:5 | flag | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/tst.go:32:2:32:5 | flag | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg1/tst.go:62:7:62:15 | NameClash | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg1 | | ||
| pkg2/tst.go:4:2:4:2 | g | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg2 | | ||
| pkg2/tst.go:8:2:8:2 | g | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg2 | | ||
| pkg2/tst.go:17:2:17:8 | NCField | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types/pkg2 | | ||
| struct_tags.go:4:2:4:7 | field1 | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| struct_tags.go:5:2:5:7 | field2 | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| struct_tags.go:9:2:9:7 | field1 | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| struct_tags.go:10:2:10:7 | field2 | package github.com/github/codeql-go/ql/test/library-tests/semmle/go/Types | | ||
| aliases.go:6:26:6:26 | x | package codeql-go-types | | ||
| aliases.go:8:26:8:26 | x | package codeql-go-types | | ||
| aliases.go:19:17:19:17 | x | package codeql-go-types | | ||
| aliases.go:29:34:29:34 | x | package codeql-go-types | | ||
| cyclic.go:4:3:4:3 | s | package codeql-go-types | | ||
| cyclic.go:8:3:8:3 | u | package codeql-go-types | | ||
| cyclic.go:9:2:9:2 | f | package codeql-go-types | | ||
| cyclic.go:13:2:13:2 | t | package codeql-go-types | | ||
| cyclic.go:17:2:17:2 | s | package codeql-go-types | | ||
| depth.go:6:2:6:2 | b | package codeql-go-types | | ||
| depth.go:7:2:7:2 | c | package codeql-go-types | | ||
| depth.go:11:2:11:2 | f | package codeql-go-types | | ||
| depth.go:15:2:15:2 | d | package codeql-go-types | | ||
| depth.go:19:2:19:2 | f | package codeql-go-types | | ||
| embedded.go:4:2:4:2 | A | package codeql-go-types | | ||
| embedded.go:8:3:8:5 | Baz | package codeql-go-types | | ||
| embedded.go:12:2:12:4 | Qux | package codeql-go-types | | ||
| embedded.go:13:2:13:4 | Baz | package codeql-go-types | | ||
| generic.go:4:2:4:11 | valueField | package codeql-go-types | | ||
| generic.go:5:2:5:13 | pointerField | package codeql-go-types | | ||
| generic.go:6:2:6:11 | arrayField | package codeql-go-types | | ||
| generic.go:7:2:7:11 | sliceField | package codeql-go-types | | ||
| generic.go:8:2:8:9 | mapField | package codeql-go-types | | ||
| generic.go:12:2:12:13 | pointerField | package codeql-go-types | | ||
| generic.go:16:2:16:5 | root | package codeql-go-types | | ||
| generic.go:20:2:20:12 | structField | package codeql-go-types | | ||
| generic.go:21:2:21:9 | mapField | package codeql-go-types | | ||
| generic.go:25:2:25:12 | structField | package codeql-go-types | | ||
| generic.go:29:2:29:13 | pointerField | package codeql-go-types | | ||
| main.go:18:7:18:15 | NameClash | package codeql-go-types | | ||
| pkg1/embedding.go:19:23:19:26 | base | package codeql-go-types/pkg1 | | ||
| pkg1/embedding.go:22:27:22:30 | base | package codeql-go-types/pkg1 | | ||
| pkg1/embedding.go:25:24:25:31 | embedder | package codeql-go-types/pkg1 | | ||
| pkg1/embedding.go:28:24:28:31 | embedder | package codeql-go-types/pkg1 | | ||
| pkg1/embedding.go:36:2:36:5 | base | package codeql-go-types/pkg1 | | ||
| pkg1/embedding.go:37:2:37:2 | f | package codeql-go-types/pkg1 | | ||
| pkg1/promotedStructs.go:5:2:5:7 | SField | package codeql-go-types/pkg1 | | ||
| pkg1/promotedStructs.go:14:2:14:7 | PField | package codeql-go-types/pkg1 | | ||
| pkg1/promotedStructs.go:22:22:22:22 | S | package codeql-go-types/pkg1 | | ||
| pkg1/promotedStructs.go:25:22:25:22 | P | package codeql-go-types/pkg1 | | ||
| pkg1/tst.go:6:2:6:2 | f | package codeql-go-types/pkg1 | | ||
| pkg1/tst.go:7:2:7:4 | Foo | package codeql-go-types/pkg1 | | ||
| pkg1/tst.go:8:2:8:4 | Bar | package codeql-go-types/pkg1 | | ||
| pkg1/tst.go:12:2:12:4 | Foo | package codeql-go-types/pkg1 | | ||
| pkg1/tst.go:13:2:13:4 | Bar | package codeql-go-types/pkg1 | | ||
| pkg1/tst.go:17:3:17:5 | Foo | package codeql-go-types/pkg1 | | ||
| pkg1/tst.go:18:3:18:5 | Bar | package codeql-go-types/pkg1 | | ||
| pkg1/tst.go:22:3:22:5 | Foo | package codeql-go-types/pkg1 | | ||
| pkg1/tst.go:23:2:23:4 | Bar | package codeql-go-types/pkg1 | | ||
| pkg1/tst.go:27:2:27:4 | val | package codeql-go-types/pkg1 | | ||
| pkg1/tst.go:28:2:28:5 | flag | package codeql-go-types/pkg1 | | ||
| pkg1/tst.go:32:2:32:5 | flag | package codeql-go-types/pkg1 | | ||
| pkg1/tst.go:62:7:62:15 | NameClash | package codeql-go-types/pkg1 | | ||
| pkg2/tst.go:4:2:4:2 | g | package codeql-go-types/pkg2 | | ||
| pkg2/tst.go:8:2:8:2 | g | package codeql-go-types/pkg2 | | ||
| pkg2/tst.go:17:2:17:8 | NCField | package codeql-go-types/pkg2 | | ||
| struct_tags.go:4:2:4:7 | field1 | package codeql-go-types | | ||
| struct_tags.go:5:2:5:7 | field2 | package codeql-go-types | | ||
| struct_tags.go:9:2:9:7 | field1 | package codeql-go-types | | ||
| struct_tags.go:10:2:10:7 | field2 | package codeql-go-types | |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.