Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Fix calls with no target in DB quality query #18166

Merged
merged 5 commits into from
Dec 2, 2024
Merged

C#: Fix calls with no target in DB quality query #18166

merged 5 commits into from
Dec 2, 2024

Conversation

tamasvajk
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the C# label Nov 29, 2024
@tamasvajk tamasvajk changed the title C#: WIP: Fix calls with no target in DB quality query C#: Fix calls with no target in DB quality query Dec 2, 2024
@tamasvajk tamasvajk marked this pull request as ready for review December 2, 2024 10:55
@tamasvajk tamasvajk requested a review from a team as a code owner December 2, 2024 10:55
@tamasvajk tamasvajk added the no-change-note-required This PR does not need a change note label Dec 2, 2024
@tamasvajk
Copy link
Contributor Author

I've added the no change note required label, because we've already added a change note earlier: https://github.com/github/codeql/blob/main/csharp/ql/src/change-notes/2024-11-28-db-quality-property-access.md

michaelnebel
michaelnebel previously approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @tamasvajk !

csharp/ql/test/query-tests/Telemetry/DatabaseQuality/Quality.cs Outdated Show resolved Hide resolved
@tamasvajk tamasvajk merged commit 8375c49 into github:main Dec 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelnebel michaelnebel michaelnebel approved these changes

Assignees
No one assigned
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamasvajk @michaelnebel