Skip to content

Data flow: Rework reverse flow through parameters#18109

Draft
hvitved wants to merge 12 commits intogithub:mainfrom
hvitved:dataflow/reverse-flow
Draft

Data flow: Rework reverse flow through parameters#18109
hvitved wants to merge 12 commits intogithub:mainfrom
hvitved:dataflow/reverse-flow

Conversation

@hvitved
Copy link
Copy Markdown
Contributor

@hvitved hvitved commented Nov 26, 2024

No description provided.

@hvitved hvitved force-pushed the dataflow/reverse-flow branch from 8d261e5 to 2e254e4 Compare November 26, 2024 13:03
@hvitved hvitved force-pushed the dataflow/reverse-flow branch 4 times, most recently from 8f34281 to f37447b Compare December 2, 2024 13:48
@hvitved hvitved force-pushed the dataflow/reverse-flow branch 8 times, most recently from a2dc9b1 to 13b8249 Compare December 9, 2024 12:37
@github-actions github-actions Bot removed the Python label Dec 9, 2024
Comment thread shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll Fixed
@hvitved hvitved force-pushed the dataflow/reverse-flow branch 7 times, most recently from 3b814f0 to d0673a1 Compare December 12, 2024 19:36
Comment thread shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll Fixed
@hvitved hvitved force-pushed the dataflow/reverse-flow branch 3 times, most recently from 6534946 to 296d8fb Compare December 13, 2024 13:44
Comment thread shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll Fixed
@hvitved hvitved force-pushed the dataflow/reverse-flow branch from 296d8fb to 45c5da2 Compare December 13, 2024 14:14
)
or
// flow through: no prior read
exists(ArgNode arg |

Check warning

Code scanning / CodeQL

Candidate predicate not marked as `nomagic`

Candidate predicate to [loadStep](1) is not marked as nomagic.
Comment thread shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll Fixed
) {
exists(ParameterPosition pos |
parameterValueFlowsToPreUpdate(p, n) and
p.isParameterOf(_, pos) and

Check warning

Code scanning / CodeQL

Candidate predicate not marked as `nomagic`

Candidate predicate to [reducedViableImplInCallContext](1) is not marked as nomagic. Candidate predicate to [reducedViableImplInCallContext](2) is not marked as nomagic.
) {
c = getNodeEnclosingCallable(n) and
paramReturnNode(n, p, _, kind)
}

Check warning

Code scanning / CodeQL

Candidate predicate not marked as `nomagic`

Candidate predicate to [reducedViableImplInReturn](1) is not marked as nomagic. Candidate predicate to [reducedViableImplInReturn](2) is not marked as nomagic.
@hvitved hvitved force-pushed the dataflow/reverse-flow branch from 45c5da2 to 23d552e Compare December 13, 2024 14:22
@hvitved hvitved force-pushed the dataflow/reverse-flow branch from 23d552e to d84ca39 Compare December 20, 2024 14:00
// flow out of a callable
exists(ReturnPosition pos |
revFlowOut(_, node, pos, state, _, _, _, ap) and
exists(DataFlowCall call, ReturnPosition pos |

Check warning

Code scanning / CodeQL

Omittable 'exists' variable

This exists variable can be omitted by using a don't-care expression [in this argument](1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants