Rust: Extend data flow library instantiation for global data flow #18056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
requested changes
Nov 21, 2024
| /** | ||
| * The value of a parameter at function entry, viewed as a node in a data | ||
| * flow graph. | ||
| */ | ||
| final class ParameterNode extends AstCfgFlowNode, TParameterNode { | ||
| final class NormalParameterNode extends ParameterNode, TParameterNode { |
There was a problem hiding this comment.
Perhaps PositionalParameterNode instead?
| Node getPreUpdateNode() { none() } | ||
| Node getPreUpdateNode() { result = TExprNode(n) } | ||
|
|
||
| final override CfgScope getCfgScope() { result = n.getAstNode().getEnclosingCfgScope() } |
|
|
||
| final override CfgScope getCfgScope() { result = n.getAstNode().getEnclosingCfgScope() } | ||
|
|
||
| final override Location getLocation() { result = n.getAstNode().getLocation() } |
There was a problem hiding this comment.
No need for the intermediate .getAstNode()
|
|
||
| final override Location getLocation() { result = n.getAstNode().getLocation() } | ||
|
|
||
| final override string toString() { result = n.getAstNode().toString() } |
There was a problem hiding this comment.
No need for the intermediate .getAstNode()
| @@ -185,7 +230,10 @@ module Node { | |||
|
|
|||
| /** A data flow node that represents a value returned by a callable. */ | |||
| final class ReturnNode extends ExprNode { | |||
| ReturnNode() { this.getCfgNode().getASuccessor() instanceof ExitCfgNode } | |||
| ReturnNode() { | |||
| this.getCfgNode().getASuccessor() instanceof ExitCfgNode or | |||
There was a problem hiding this comment.
Is this disjunct actually needed?
| predicate isParameterNode(ParameterNode p, DataFlowCallable c, ParameterPosition pos) { none() } | ||
| /** Holds if `p` is a parameter of `c` at the position `pos`. */ | ||
| predicate isParameterNode(ParameterNode p, DataFlowCallable c, ParameterPosition pos) { | ||
| p.getCfgNode().getAstNode() = pos.getParameterIn(c.asCfgScope().(Function).getParamList()) |
There was a problem hiding this comment.
Use Callable instead of Function to also include closures.
| cached | ||
| newtype TParameterPosition = | ||
| TPositionalParameterPosition(int i) { | ||
| exists(any(ParamList l).getParam(i)) or exists(any(ArgList l).getArg(i)) |
There was a problem hiding this comment.
Alternatively, i in [0 .. max([any(ParamList l).getNumberOfParams(), any(ArgList l).getNumberOfArgs()] - 1].
| testFailures | ||
| | main.rs:45:10:45:10 | a | Fixed missing result: hasValueFlow=14 | |
There was a problem hiding this comment.
The MISSING marked should be removed in the test.
|
I've addressed the comments and started a DCA run :) |
hvitved
requested changes
Nov 22, 2024
| @@ -231,7 +231,7 @@ module Node { | |||
| /** A data flow node that represents a value returned by a callable. */ | |||
| final class ReturnNode extends ExprNode { | |||
| ReturnNode() { | |||
| this.getCfgNode().getASuccessor() instanceof ExitCfgNode or | |||
| // this.getCfgNode().getASuccessor() instanceof ExitCfgNode or | |||
paldepind
force-pushed
the
rust-df-global
branch
from
fb62e7a
to
e81c348
Compare
hvitved
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.