Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Remove FPs from cpp/too-few-arguments #17919

Merged
merged 6 commits into from
Nov 22, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
C++: Address review comments
calumgrant committed Nov 22, 2024
commit 60155ce2052ec22a9ed6e1c5cdeba92bda740003
2 changes: 1 addition & 1 deletion cpp/ql/src/change-notes/2024-11-22-too-few-arguments.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
---
category: minorAnalysis
---
* The "Call to function with fewer arguments than declared parameters" query (`cpp/too-few-arguments`) query produces no results if the function has been implicitly declared.
* The "Call to function with fewer arguments than declared parameters" query (`cpp/too-few-arguments`) query no longer produces results if the function has been implicitly declared.
Original file line number Diff line number Diff line change
@@ -31,7 +31,7 @@ void test(int *argv[]) {
not_yet_declared1(1); // BAD (GOOD for everything except for cpp/implicit-function-declaration)
not_yet_declared2(1); // BAD (GOOD for everything except for cpp/implicit-function-declaration)
not_yet_declared2(ca); // BAD (GOOD for everything except for cpp/mistyped-function-arguments)
not_yet_declared2(); // GOOD
not_yet_declared2(); // BAD [NOT DETECTED] (GOOD for everything except for cpp/too-few-arguments)

declared_empty_defined_with(); // BAD
declared_empty_defined_with(1); // GOOD