Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: integrate rust code generation into //rust/codegen #17682

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Oct 8, 2024

Now bazel run //rust/codegen will run both the rust code generation and the python-based one from codegen.

Other changes:

  • some tweaks were made by clippy
  • the shuffling of the newlines in ast.py was needed to avoid the endline fixing in pre-commit to kick in
  • some .. paths needed to be replaced by project_root()
  • the generated rust code is now excluded from formatting

@redsun82 redsun82 requested a review from aibaars October 8, 2024 09:14
@redsun82 redsun82 requested a review from a team as a code owner October 8, 2024 09:14
@github-actions github-actions bot added the Rust Pull requests that update Rust code label Oct 8, 2024
Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@aibaars aibaars merged commit 4ab9255 into main Oct 8, 2024
25 checks passed
@aibaars aibaars deleted the redsun82/rust-codegen branch October 8, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants