Add support for Kotlin 2.1.0-Beta1 #17555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igfoo
force-pushed
the
igfoo/kotlin2.1
branch
2 times, most recently
from
00949e9
to
f701d5a
Compare
tamasvajk
reviewed
Sep 25, 2024
| --- | ||
| category: feature | ||
| --- | ||
| * Kotlin versions up to 2.1.0\ *x* are now supported. |
There was a problem hiding this comment.
I don't understand this 2.1.0\ *x* version. Shouldn't we instead say we support versions up to 2.1.*?
There was a problem hiding this comment.
Kotlin doesn't guarantee that interfaces won't change between e.g. 2.1.0 and 2.1.10.
This text makes more sense for 2.1.1x, where the final component is 2 digits. The intention here is to include e.g. 2.1.5, but that is unfortunately not written 2.1.05. I'm not sure we can concisely write something better, though.
tamasvajk
approved these changes
Sep 25, 2024
igfoo
force-pushed
the
igfoo/kotlin2.1
branch
from
f701d5a
to
a6fce19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.