Ruby: Minor fixes for dataflow queries #14274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrford
changed the title
hvitved
previously approved these changes
Sep 20, 2023
aschackmull
requested changes
Sep 21, 2023
There was a problem hiding this comment.
We shouldn't deprecate DataFlow2 just yet. It's part of the old configuration-class API, which we will bulk-deprecate in December, cf. https://github.blog/changelog/2023-08-14-new-dataflow-api-for-writing-custom-codeql-queries/
alexrford
force-pushed
the
rb/dataflow-tidy
branch
from
28c7a4c
to
4cb91e0
Compare
aschackmull
previously approved these changes
Sep 21, 2023
Not sure how I missed these - deleted. |
hvitved
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #14124 to address some issues:
rb/improper-ldap-authwas not converted due to being merged around the same time - this is done hereDataFlow2. Ideally we would just be able to removeDataFlow2, but it's available for external queries so I think we need to deprecate it first.