Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: Lift getParameter to ParameterNode #14269

Merged
merged 2 commits into from
Sep 21, 2023
Merged

C++: Lift getParameter to ParameterNode #14269

merged 2 commits into from
Sep 21, 2023

Conversation

MathiasVP
Copy link
Contributor

@MathiasVP MathiasVP requested a review from a team as a code owner September 20, 2023 08:54
@MathiasVP MathiasVP added the no-change-note-required This PR does not need a change note label Sep 20, 2023
@github-actions github-actions bot added the C++ label Sep 20, 2023
@aschackmull
Copy link
Contributor

Is Node.asParameter() not sufficient?

@MathiasVP
Copy link
Contributor Author

Is Node.asParameter() not sufficient?

That would have also worked, yes.

geoffw0
geoffw0 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MathiasVP MathiasVP merged commit 3d8231b into github:main Sep 21, 2023
8 checks passed
@pwntester
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MathiasVP @aschackmull @pwntester @geoffw0