Swift: upgrade to 5.9

[AlexDenisov]

No description provided.

[redsun82]

"may" makes it sound like the statement would be optional. Maybe

Suggested change

	An expression that may wrap a statement which produces a single value.
	An expression that wraps a statement which produces a single value.

[AlexDenisov]

That's what the docs from compiler sources said 🤷

[redsun82]

Hmm, then we should probably double-check whether Stmt should not be optional (I would be surprised if it could though). If not, then I would drop the may regardless of the internal compiler docs (which by the way we shouldn't really copy 😉).

[geoffw0]

The library changes and upgrade / downgrade scripts LGTM.

[geoffw0]

I'm happy, once @redsun82 and the checks and the DCA job are all happy.

[AlexDenisov]

• DCA looks great
• I'll take care about change note for the next release (unless we need to add that we now extract one more AST node)
• and the QLDoc failure can be ignored as it will be fixed after Swift: add more doc strings to generated things #14715

@geoffw0 @redsun82 anything else you'd like to see?

[geoffw0]

Well I don't understand what's going on with the change note, but I remain happy with this PR. @redsun82 can approve if his concerns have been addressed.

the QLDoc failure can be ignored as it will be fixed after #14715

I think when one of these two PRs is merged, the other will need updating.

[AlexDenisov]

Well I don't understand what's going on with the change note, but I remain happy with this PR

AFAICT, currently we only have space for QL-related change notes. I'd like to include a note saying that we now support Swift 5.9, but previously I had to talk to a release manager to make this happen.

I think when one of these two PRs is merged, the other will need updating.

For sure, I hope this one gets in first though 😅

[redsun82]

unless we need to add that we now extract one more AST node

More or less this. From the library perspective, there is a new class, so it's probably worth mentioning that. * added `SingleValueStmtExpr`. would probably be enough, I think?

[AlexDenisov]

unless we need to add that we now extract one more AST node

More or less this. From the library perspective, there is a new class, so it's probably worth mentioning that. * added `SingleValueStmtExpr`. would probably be enough, I think?

I'll do in the followup PR then, I don't want to restart the whole CI process for this PR. (unless there is some other changes need to happen here).

[geoffw0]

AFAICT, currently we only have space for QL-related change notes. I'd like to include a note saying that we now support Swift 5.9, but previously I had to talk to a release manager to make this happen.

I feel that the library change notes are an appropriate place to describe extractor changes (i.e. swift\ql\lib\change-notes), if we do not have separate extractor change notes.

[AlexDenisov]

@redsun82 @geoffw0 I added change note.

[geoffw0]

I think this is ready to merge. Please check that @redsun82 agrees before merging.

[redsun82]

Thanks for the terrific work on this!