Skip to content

Fix misspelling of asynchronous in SIG30-C #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025
+10 −8
Merged

Fix misspelling of asynchronous in SIG30-C #926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da92563
Fix misspelling of asynchronous in SIG30-C
jketema Jul 10, 2025
56258d1
Add change note
jketema Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions c/cert/src/rules/SIG30-C/CallOnlyAsyncSafeFunctionsWithinSignalHandlers.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@ class AsyncSafeVariableAccess extends VariableAccess {
abstract class AsyncSafeFunction extends Function { }

/**
* C standard library ayncronous-safe functions
* C standard library asynchronous-safe functions
*/
class CAsyncSafeFunction extends AsyncSafeFunction {
//tion, or the signal function with the first argument equal to the signal number corresponding to the signal that caused the invocation of the handler
CAsyncSafeFunction() { this.hasGlobalName(["abort", "_Exit", "quick_exit", "signal"]) }
}

/**
* POSIX defined ayncronous-safe functions
* POSIX defined asynchronous-safe functions
*/
class PosixAsyncSafeFunction extends AsyncSafeFunction {
PosixAsyncSafeFunction() {
Expand Down Expand Up @@ -73,7 +73,7 @@ class PosixAsyncSafeFunction extends AsyncSafeFunction {
}

/**
* Application defined ayncronous-safe functions
* Application defined asynchronous-safe functions
*/
class ApplicationAsyncSafeFunction extends AsyncSafeFunction {
pragma[nomagic]
Expand Down Expand Up @@ -122,5 +122,5 @@ where
or
fc instanceof AsyncUnsafeRaiseCall
)
select fc, "Asyncronous-unsafe function calls within a $@ can lead to undefined behavior.",
select fc, "Asynchronous-unsafe function calls within a $@ can lead to undefined behavior.",
handler.getRegistration(), "signal handler"
8 changes: 4 additions & 4 deletions c/cert/test/rules/SIG30-C/CallOnlyAsyncSafeFunctionsWithinSignalHandlers.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
WARNING: module 'DataFlow' has been deprecated and may be removed in future (CallOnlyAsyncSafeFunctionsWithinSignalHandlers.ql:110,11-19)
WARNING: module 'DataFlow' has been deprecated and may be removed in future (CallOnlyAsyncSafeFunctionsWithinSignalHandlers.ql:110,31-39)
WARNING: module 'DataFlow' has been deprecated and may be removed in future (CallOnlyAsyncSafeFunctionsWithinSignalHandlers.ql:111,9-17)
| test.c:10:3:10:18 | call to log_local_unsafe | Asyncronous-unsafe function calls within a $@ can lead to undefined behavior. | test.c:16:7:16:12 | call to signal | signal handler |
| test.c:11:3:11:6 | call to free | Asyncronous-unsafe function calls within a $@ can lead to undefined behavior. | test.c:16:7:16:12 | call to signal | signal handler |
| test.c:46:3:46:9 | call to longjmp | Asyncronous-unsafe function calls within a $@ can lead to undefined behavior. | test.c:50:7:50:12 | call to signal | signal handler |
| test.c:76:7:76:11 | call to raise | Asyncronous-unsafe function calls within a $@ can lead to undefined behavior. | test.c:91:7:91:12 | call to signal | signal handler |
| test.c:10:3:10:18 | call to log_local_unsafe | Asynchronous-unsafe function calls within a $@ can lead to undefined behavior. | test.c:16:7:16:12 | call to signal | signal handler |
| test.c:11:3:11:6 | call to free | Asynchronous-unsafe function calls within a $@ can lead to undefined behavior. | test.c:16:7:16:12 | call to signal | signal handler |
| test.c:46:3:46:9 | call to longjmp | Asynchronous-unsafe function calls within a $@ can lead to undefined behavior. | test.c:50:7:50:12 | call to signal | signal handler |
| test.c:76:7:76:11 | call to raise | Asynchronous-unsafe function calls within a $@ can lead to undefined behavior. | test.c:91:7:91:12 | call to signal | signal handler |
2 changes: 2 additions & 0 deletions change_notes/2025-07-11-typo-in-alert-message..md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `SIG30-C`: `CallOnlyAsyncSafeFunctionsWithinSignalHandlers.ql`
- Fixed a misspelling of "asynchronous" in the alert message.
Loading