Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rvermeulen/address non terminal non zero exit codes #436

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Rvermeulen/address non terminal non zero exit codes #436

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff87796
Use a subshell to wrap the gh command
rvermeulen Nov 17, 2023
901a97e
Prevent globbing and word splitting
rvermeulen Nov 17, 2023
72a9907
Reduce the description that is part of the UI
rvermeulen Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/prepare-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
required: true
hotfix:
description: |
Whether this is a hotfix release.
Hotfix release.
required: false
default: false
type: boolean
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ github.token }}
run: |
release_pr=$(gh pr view rc/$RELEASE_VERSION --json title,state,number)
release_pr=$( { gh pr view "rc/$RELEASE_VERSION" --json title,state,number; } || echo "")
if [[ ! -z "$release_pr" ]]; then
pr_title=$(echo "$release_pr" | jq -r '.title')
pr_state=$(echo "$release_pr" | jq -r '.state')
Expand Down
Loading