-
Notifications
You must be signed in to change notification settings - Fork 362
Improve JSON validation in start-proxy
action
#2956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
startProxyExports.getCredentials( | ||
getRunnerLogger(true), | ||
undefined, | ||
testCredential, | ||
undefined, | ||
), |
Check failure
Code scanning / CodeQL
Untrusted data passed to external API with additional heuristic sources High Experimental
getToke ... word(e)
startProxyExports.getCredentials( | ||
getRunnerLogger(true), | ||
undefined, | ||
testCredential, | ||
undefined, | ||
), |
Check failure
Code scanning / CodeQL
Untrusted data passed to external API with additional heuristic sources High Experimental
getToke ... word(e)
undefined, | ||
); | ||
for (const credential of credentials) { | ||
t.not(credential.token, undefined); |
Check failure
Code scanning / CodeQL
Untrusted data passed to external API with additional heuristic sources High Experimental
getToke ... word(e)
); | ||
for (const credential of credentials) { | ||
t.not(credential.token, undefined); | ||
t.is(credential.password, undefined); |
Check failure
Code scanning / CodeQL
Untrusted data passed to external API with additional heuristic sources High Experimental
getToke ... word(e)
Call to ava.[callback].[param 't'].is() [param 0] with untrusted data from
This PR makes three changes related to the
start-proxy
action:null
values as meaningful.password
is actually atoken
, which can lead to confusion when inspecting the logs and seeing thattoken
isundefined
even when it is expected to be defined. We believe thatusername
is alwaysundefined
in that case, so we can use that as an indicator to treat thepassword
as thetoken
instead.Merge / deployment checklist