Repository navigation
Post Deploy Fixes - #183
Merged
Merged
Conversation
Shaeli
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post Deploy Fixes
This pull request makes the "post deploy" step a bit more resilient. In some cases, a network blip or another process removing the lock file could result in the
lock()method returningnullfor the lock data in the "post deploy" step. This would cause the final post deploy step to fail.By using the
?.operator in JS combined with checking fornullorundefinedvalues, we can guard ourselves from this edge case.