Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHSA-29mw-wpgm-hmr9] Regular Expression Denial of Service (ReDoS) in lodash #2857

Conversation

DmitriyLewen
Copy link

@DmitriyLewen DmitriyLewen commented Oct 16, 2023

Updates

  • Affected products

Comments
Hello!
If i understand correctly, lodash team has moved lodash.trim and lodash.trimend packages inside lodash package:
https://github.com/lodash/lodash/tree/npm-packages/lodash.trim => https://github.com/lodash/lodash/blob/npm/trim.js
They have stopped updating of these packages:
https://www.npmjs.com/package/lodash.trim
https://www.npmjs.com/package/lodash.trimend

I checked code and looks like there is no fix for this CVE for these packages:
e.g.:
lodash.trimend still uses string.replace(reTrimEnd, '')(with /\s+$/ value) - https://github.com/lodash/lodash/blob/aaa111912cb05e6f0f9f23d1eb8a41ccfcf9c2c2/lodash.trimend/index.js#L356 (fix of this - https://github.com/lodash/lodash/pull/5065/files#diff-36b7ba0ba252cc39fa5921d9484b7674c8bc7af119636ba7f46194ee871047b6R15046).

I could be wrong. Can you take a look and correct me/update this advisory.

Thank you in advance!
Best Regards, Dmitriy

@github-actions github-actions bot changed the base branch from main to DmitriyLewen/advisory-improvement-2857 October 16, 2023 04:21
@CallmeMari
Copy link

Hi @DmitriyLewen, we appreciate your contribution to the GitHub Advisory Database. Just to confirm we are reviewing the fix to the correct CVE can you please specify which CVE you are referring to? It would be helpful to include any references that validate your proposed change :)

@DmitriyLewen
Copy link
Author

I said about CVE-2020-28500 (GHSA-29mw-wpgm-hmr9)

@advisory-database advisory-database bot merged commit f1ecaa3 into DmitriyLewen/advisory-improvement-2857 Oct 18, 2023
2 checks passed
@advisory-database advisory-database bot deleted the DmitriyLewen-GHSA-29mw-wpgm-hmr9 branch October 18, 2023 22:34
@advisory-database
Copy link
Contributor

Hi @DmitriyLewen! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants