Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHSA-mrx7-8hxf-f853] Cross-Site Scripting in swagger-ui #2834

Conversation

tdunlap607
Copy link
Contributor

Updates

  • References

Comments
Adding the patch links for:
v2.2.1: swagger-api/swagger-ui@331d2be

This is from the PR (1869) that closed the original issue (1863): "Escape curl command to fix XSS vulnerability."

@github-actions github-actions bot changed the base branch from main to tdunlap607/advisory-improvement-2834 October 9, 2023 19:00
@darakian
Copy link
Contributor

Are you sure that's the correct fix commit? Based on the description I think this one may also be a candidate
swagger-api/swagger-ui@a1aea70

@tdunlap607
Copy link
Contributor Author

@darakian Hi! I think we've found a potential duplicate security advisory. I used commit swagger-api/swagger-ui@a1aea70 for this advisory: GHSA-g336-c7wv-8hp3. The pull pointed back to the original issue of 1617.

This advisory (GHSA-mrx7-8hxf-f853) has the issue 1863, which was closed by swagger-api/swagger-ui@331d2be.

It seems like we should potentially combine the two advisories (GHSA-mrx7-8hxf-f853 & GHSA-g336-c7wv-8hp3) into a single advisory. Also, I just noticed that this advisory's referenced CVE (https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-1000233) was reserved but never used -> https://nvd.nist.gov/vuln/detail/CVE-2016-1000233

@darakian
Copy link
Contributor

It seems like we should potentially combine the two advisories...

I would love to. We really need to build that merge functionality 😅
I guess for now we'll got with swagger-api/swagger-ui@331d2be for this one. I missed the PR link. Thanks for the catch 👍

@advisory-database advisory-database bot merged commit 0035e0d into tdunlap607/advisory-improvement-2834 Oct 10, 2023
2 checks passed
@advisory-database advisory-database bot deleted the tdunlap607-GHSA-mrx7-8hxf-f853 branch October 10, 2023 21:02
@advisory-database
Copy link
Contributor

Hi @tdunlap607! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants