Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHSA-xjw2-6jm9-rf67] Sandbox escape via various forms of "format". #2689

Conversation

m3t3kh4n
Copy link

Updates

  • Affected products
  • CVSS
  • CWEs
  • Severity

Comments

  • CWE was incorrect and it was changed.
  • Initial CVSS assessment was conducted.

@github
Copy link
Collaborator

github commented Aug 31, 2023

Hi there @icemac! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@github-actions github-actions bot changed the base branch from main to m3t3kh4n/advisory-improvement-2689 August 31, 2023 12:17
Copy link

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with these changes.

@shelbyc
Copy link
Contributor

shelbyc commented Sep 6, 2023

Hi @m3t3kh4n and @icemac, I'm interested in learning more about how you reached the conclusions about the appropriate CVSS and CVE for this advisory.

For the CVSS: Sandbox escape usually has some impact on data integrity and availability, but I see that the description only mentions critical information disclosure. Is there a possibility for data integrity and availability impact?

How did each of you choose the CWE you felt was most appropriate?

@icemac
Copy link

icemac commented Sep 7, 2023

The values I chose were best guesses as I did this for the first time, so I probably chose unnecessary high values.

@shelbyc
Copy link
Contributor

shelbyc commented Sep 7, 2023

@icemac Scoring a vulnerability and finding an appropriate CVE can be an uncertain process even for people who work with CVE data every day, and I want to make sure we respect your perspective as the maintainer. 🙂 The most important thing is getting an accurate understanding of the vulnerability. If it's possible for someone to use the vulnerability to mess with data integrity or crash the software or system, we can reflect that in the CVSS. If the only impact is disclosing data when the data shouldn't be disclosed, we can reflect that in the CVSS too.

I'm also happy to answer questions!

@taladrane
Copy link
Collaborator

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the Keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot. Please see CONTRIBUTING.md for more policy details.

@taladrane taladrane closed this Oct 8, 2023
@github-actions github-actions bot deleted the m3t3kh4n-GHSA-xjw2-6jm9-rf67 branch October 8, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants