Migrate scanner workflow to v3.4.0 NPM plugin loading - #62
Merged
Conversation
Pin accessibility-scanner v3.4.0 by commit and load the alt-text plugin from its immutable npm 1.1.0 release. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 322c76db-d9b5-4400-b3a9-f5061ea99eb7
There was a problem hiding this comment.
Pull request overview
Migrates static-site scans to scanner v3.4.0 and the published alt-text plugin.
Changes:
- Pins scanner v3.4.0.
- Loads plugin package v1.1.0.
- Removes local checkout and staging.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/scan-static-sites.yml |
Updates scanner and plugin loading configuration. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Medium
JoyceZhu
previously approved these changes
Jul 28, 2026
JoyceZhu
left a comment
JoyceZhu
left a comment
Contributor
There was a problem hiding this comment.
Thanks for double checking whether the Copilot comment is legit first (seems like not)
Scanner v3.4.0 installs NPM plugins in the consumer workspace but imports them relative to the action module, so keep the proven local loading path until a fixed scanner release is available. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 322c76db-d9b5-4400-b3a9-f5061ea99eb7
taarikashenafi
changed the title
taarikashenafi
changed the title
Restore the package-loading workflow approved on the original PR revision. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 322c76db-d9b5-4400-b3a9-f5061ea99eb7
There was a problem hiding this comment.
Review details
Comments suppressed due to low confidence (1)
.github/workflows/scan-static-sites.yml:62
- The v3.4.0 loader installs this package under
GITHUB_WORKSPACEbut executesimport(request.package)from the scanner action under_actions, so Node cannot resolve the newly installed package. The loader catches that failure and skipsalt-text-scan, leaving this workflow to run only Axe. This reintroduces the module-resolution failure previously reproduced in this PR; retain local staging until the scanner installs and imports from the same location.
scans: |
["axe", {"name": "alt-text-scan", "package": "@github/accessibility-scanner-alt-text-plugin", "version": "1.1.0"}]
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Medium
Contributor
Author
|
ignore everything between second and third commit, that was the work of copilot not me haha. third commit restores the state where you approved originally. |
JoyceZhu
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the scanner action to v3.4.0 and loads the alt-text plugin from npm (
@github/accessibility-scanner-alt-text-plugin@1.1.0) via the new object form of thescansinput.Since v3.4.0 can resolve plugins as packages, we no longer need to check out this repo and copy
index.ts/srcinto.github/scanner-plugins/before the scan, so those two steps are gone. Everything else (urls, cache keys, target repo, token,skip_copilot_assignment) is unchanged.I didn't dispatch the workflow itself, it scans live sites and writes issues/cache, but I ran v3.4.0's plugin loader against the published package locally and confirmed it kept
axeand picked up thealt-text-scanexport.Revert to go back to v3.3.0 with local plugin staging; nothing to migrate.