Skip to content

Review of accessibility-scanner and alt-text-plugin repos and their branches - #50

Closed
kzhou314 with Copilot wants to merge 1 commit into
mainfrom
copilot/review-accessibility-scanner
Closed

Review of accessibility-scanner and alt-text-plugin repos and their branches#50
kzhou314 with Copilot wants to merge 1 commit into
mainfrom
copilot/review-accessibility-scanner

Conversation

Copilot AI commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review of the full workspace — both github/accessibility-scanner (core engine) and github/accessibility-scanner-alt-text-plugin (this repo) — including their branches, with a summary of each. This is a read-only review; no files were changed.

github/accessibility-scanner — core engine

  • GitHub Action (@v3) that scans for a11y barriers, files issues, and assigns Copilot for AI fixes. TypeScript/ESM, Vitest, MIT, public preview.
  • Sub-actions under .github/actions/: find, fix, file, auth, gh-cache; composite entrypoint in action.yml.
  • Dynamic plugin system (PLUGINS.md): loads .github/scanner-plugins/*, each exporting a name + default (page, addFinding) function; selectable via the scans input.
  • Release lines main/v1/v2/v3. Active branches/PRs: #242 npm plugin loading, #241 AccessLint scan engine, #224 ignore_https_errors, #223 SPA networkidle wait, plus smockle/*, lw/*, and copilot/fix-github-actions-workflow* housekeeping.

github/accessibility-scanner-alt-text-plugin — this repo

  • npm-distributed plugin (@github/accessibility-scanner-alt-text-plugin v1.0.0) flagging low-quality alt text, complementing Axe's image-alt.
  • index.ts exports name = 'alt-text-scan' + default altTextScan({page, addFinding}), matching the scanner's plugin contract; config loaded once from .github/scanner-plugins/alt-text-scan/config.json.
  • Pipeline: src/extract.ts (filters decorative/hidden/non-img) → src/rules/*src/findings.ts. Rules: missing, vague, filename, repeated, placeholder.
  • Active branches/PRs: Add repository field to fix provenance validation on publish #49 repository field for npm provenance (unblocks v1.0.0 republish), Implement copilot quality alt #38 model-backed alt-text-quality rule, taarikashenafi/* rule features, and github-advanced-security/security-review-code-scanning* runs.

How they fit together

The scanner hosts the engine and issue/fix workflow; the alt-text plugin plugs in via scans. Integration is in flight now — scanner #242 (npm plugin loading) pairs with plugin #49 (provenance fix) and the v1.0.0 release. Both share conventions: TypeScript/ESM, Vitest, ESLint + @github/prettier-config, Node ^22.13 || ^24 || ^26, MIT, and a common addFinding model.

Original prompt

review the entirely of the workspace (both the accessibility scanner and accessibility scanner plugin), including their branches. report back to me a summary of each

Created from VS Code.

GitHub Advanced Security started work on behalf of kzhou314 July 2, 2026 18:12 View session
GitHub Advanced Security finished work on behalf of kzhou314 July 2, 2026 18:12
@kzhou314 kzhou314 closed this Jul 2, 2026
Copilot AI changed the title [WIP] Review workspace including accessibility scanner and plugin Review of accessibility-scanner and alt-text-plugin repos and their branches Jul 2, 2026
Copilot AI requested a review from kzhou314 July 2, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants