-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add acceptance ratebycount for issue 113 {Show the Acceptance Rate (by count) and Acceptance Rate (by lines) #113} #115
Open
DevOps-zhuang
wants to merge
7
commits into
github-copilot-resources:main
Choose a base branch
from
DevOps-zhuang:Feature/AddAcceptanceRatebycount
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons bug for acceptance rate (by lines); remove unused variables in SeatsAnalysisViewer
… sources for top 5 accepted prompts
I think we should update the Readme and screenshots with that change |
Changes make sense to me, is this going to conflict with #116 ? |
karpikpl
approved these changes
Nov 21, 2024
…te labels, improve clarity, and reorder cards for better focus on acceptance rates by count
… enhance error handling and improve code readability
…age paths for key metrics
@karpikpl @nathenharvey can you check it? I made some updates to fix issues and update the readme. thanks. |
I'll test again and check with @martedesco if we can merge |
Thanks,I think it includes changes for both issues,it is same branch in my repo. Thanks for check)
获取 Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
发件人: Piotr Karpala ***@***.***>
发送时间: Saturday, November 23, 2024 12:50:10 AM
收件人: github-copilot-resources/copilot-metrics-viewer ***@***.***>
抄送: Junqian Zhuang ***@***.***>; Mention ***@***.***>
主题: Re: [github-copilot-resources/copilot-metrics-viewer] Feature/add acceptance ratebycount for issue 113 {Show the Acceptance Rate (by count) and Acceptance Rate (by lines) #113} (PR #115)
I'll test again and check with @martedesco<https://github.com/martedesco> if we can merge
@DevOps-zhuang<https://github.com/DevOps-zhuang> does #115<#115> needs to be merged before #116<#116> ?
―
Reply to this email directly, view it on GitHub<#115 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AM4XDKA6UUCE4ECPZYANPEL2B5OEFAVCNFSM6AAAAABSBIJUF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJUGI2TOOBSGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the Acceptance Rate (by count) and Acceptance Rate (by lines)
This pull request includes significant changes to the
BreakdownComponent.vue
andMetricsViewer.vue
components to enhance the breakdown and metrics display by adding new acceptance rate calculations and visualizations. The most important changes include modifying the layout and data representation in the breakdown component, updating the metrics viewer to display additional acceptance rate metrics, and updating the data models to support these new metrics.Changes to
BreakdownComponent.vue
:Changes to
MetricsViewer.vue
:Changes to data models:
Breakdown
class to include new fields for suggested prompts and acceptance rates by counts and lines.Metrics
class to include new fields for acceptance rates by counts and lines, and added corresponding calculations. [1] [2]https://github.com/github-copilot-resources/copilot-metrics-viewer/issues/113