Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add acceptance ratebycount for issue 113 {Show the Acceptance Rate (by count) and Acceptance Rate (by lines) #113} #115

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

DevOps-zhuang
Copy link
Contributor

Show the Acceptance Rate (by count) and Acceptance Rate (by lines)
This pull request includes significant changes to the BreakdownComponent.vue and MetricsViewer.vue components to enhance the breakdown and metrics display by adding new acceptance rate calculations and visualizations. The most important changes include modifying the layout and data representation in the breakdown component, updating the metrics viewer to display additional acceptance rate metrics, and updating the data models to support these new metrics.

Changes to BreakdownComponent.vue:

  • Modified the layout to include an additional column for displaying acceptance rate by counts and lines, and updated the chart data references accordingly. [1] [2] [3]
  • Added new fields for suggested prompts and acceptance rates by counts and lines in the template and data model. [1] [2]
  • Updated the sorting and calculation logic to handle the new acceptance rate metrics. [1] [2]

Changes to MetricsViewer.vue:

  • Updated the layout to display acceptance rate averages by lines and counts, and updated the chart data references accordingly. [1] [2] [3] [4]
  • Added new fields and calculations for acceptance rates by lines and counts in the data model and chart data. [1] [2] [3]

Changes to data models:

@karpikpl
Copy link
Collaborator

I think we should update the Readme and screenshots with that change

@karpikpl
Copy link
Collaborator

Changes make sense to me, is this going to conflict with #116 ?

@DevOps-zhuang
Copy link
Contributor Author

@karpikpl @nathenharvey can you check it? I made some updates to fix issues and update the readme. thanks.

@DevOps-zhuang
Copy link
Contributor Author

I think we should update the Readme and screenshots with that change

Yes, it is updated and new images are added as well.
image
image

@karpikpl
Copy link
Collaborator

I'll test again and check with @martedesco if we can merge
@DevOps-zhuang does #115 needs to be merged before #116 ?

@DevOps-zhuang
Copy link
Contributor Author

DevOps-zhuang commented Nov 23, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the Acceptance Rate (by count) and Acceptance Rate (by lines)
2 participants