hydration checks as fabric CRD validation #1114
Conversation
|
🚀 Temp artifacts published: |
edipascale
force-pushed
the
ema/hydration-checks
branch
from
9558ecb to
80f7990
Compare
|
🚀 Temp artifacts published: |
edipascale
force-pushed
the
ema/hydration-checks
branch
from
80f7990 to
6160bca
Compare
|
🚀 Temp artifacts published: |
edipascale
force-pushed
the
ema/hydration-checks
branch
from
6160bca to
c438989
Compare
|
🚀 Temp artifacts published: |
edipascale
force-pushed
the
ema/hydration-checks
branch
from
c438989 to
5b20270
Compare
|
🚀 Temp artifacts published: |
edipascale
force-pushed
the
ema/hydration-checks
branch
from
5b20270 to
747ca04
Compare
|
🚀 Temp artifacts published: |
|
tested this on my vm, unless the CI finds some hidden issue this should be good |
There was a problem hiding this comment.
Pull Request Overview
This PR implements hydration validation checks as part of fabric CRD validation to ensure proper configuration of network switches and connections. The changes add validation logic to verify IP address uniqueness, subnet containment, and MCLAG peer consistency.
Key changes:
- Adds comprehensive IP address validation for switches including management, protocol, and VTEP IP uniqueness checks
- Implements fabric connection IP validation for spine-leaf, mesh, and gateway connections
- Validates ASN (Autonomous System Number) consistency for spine switches and uniqueness for leaf switches
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| api/wiring/v1beta1/switch_types.go | Adds HydrationValidation method to validate switch IP addresses, ASN assignments, and MCLAG peer configurations |
| api/wiring/v1beta1/connection_types.go | Extends connection validation to check fabric IP address uniqueness and subnet containment across different connection types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
edipascale
force-pushed
the
ema/hydration-checks
branch
from
747ca04 to
ce6a217
Compare
|
🚀 Temp artifacts published: |
edipascale
force-pushed
the
ema/hydration-checks
branch
from
ce6a217 to
27c62f8
Compare
|
🚀 Temp artifacts published: |
edipascale
force-pushed
the
ema/hydration-checks
branch
from
27c62f8 to
709a591
Compare
|
🚀 Temp artifacts published: |
Signed-off-by: Emanuele Di Pascale <[email protected]>
edipascale
force-pushed
the
ema/hydration-checks
branch
from
709a591 to
9f2d14f
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Emanuele Di Pascale <[email protected]>
edipascale
force-pushed
the
ema/hydration-checks
branch
from
9f2d14f to
5c7b62f
Compare
|
🚀 Temp artifacts published: |
| // TODO: collect gateways as well for VTEP and protocol IP uniqueness checks | ||
| // (cannot be done now as gateway webhook would create a circular dependency) | ||
|
|
||
| // FIXME: ASN ranges validation is not possible as they are defined in fabricator |
There was a problem hiding this comment.
For missing data, we should extend meta.FabricConfig and pass it from the fabricator, could you please take a look into it in a new PR?
2 participants
Fix #1111