Skip to content

Conversation

@sergeymatov
Copy link
Contributor

This is the implementation of rpc GetDataplaneStatus. Real stats collection will be added separately.

@sergeymatov sergeymatov requested a review from a team as a code owner October 22, 2025 13:39
@sergeymatov sergeymatov requested review from Fredi-raspall and removed request for a team October 22, 2025 13:39
@sergeymatov sergeymatov force-pushed the pr/smatov/grpc-dataplane-status branch from 562e3a2 to e5aa699 Compare October 22, 2025 15:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the backend infrastructure for the GetDataplaneStatus gRPC endpoint. It introduces comprehensive internal data models for dataplane runtime status (interfaces, BGP, VPCs, FRR, etc.), adds gRPC conversion logic, and wires the request handling through the processor to the gRPC server. The actual collection of real-time statistics is deferred to future work.

Key Changes:

  • Added internal status data models with enums, structs, and builder methods
  • Implemented bidirectional gRPC conversions for all status types
  • Integrated new request/response flow in config processor and gRPC server

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
config/src/internal/status/mod.rs Defines comprehensive internal models for dataplane status including interfaces, BGP, VPCs, and counters
config/src/converters/grpc/status.rs Implements TryFrom conversions between internal status models and gRPC protobuf types
mgmt/src/processor/proc.rs Adds GetDataplaneStatus request/response handling to config processor
mgmt/src/grpc/server.rs Implements GetDataplaneStatus gRPC endpoint with conversion and error handling
config/src/internal/mod.rs Exposes new status module
config/src/converters/grpc/mod.rs Exports status converters and adds round-trip test
Cargo.toml Updates gateway_config dependency from v0.15.0 to v0.15.1

@sergeymatov sergeymatov force-pushed the pr/smatov/grpc-dataplane-status branch 3 times, most recently from 7baf4fc to 0cc8203 Compare October 23, 2025 08:30
Copy link
Contributor

@mvachhar mvachhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you break this into two commits, one that actually adds the server and the other one that adds the conversion code, new types, and tests? It should be too hard since I think that is a file by file split.

@sergeymatov sergeymatov force-pushed the pr/smatov/grpc-dataplane-status branch 2 times, most recently from e82bccc to 0d67af3 Compare October 27, 2025 11:35
@sergeymatov sergeymatov force-pushed the pr/smatov/grpc-dataplane-status branch from 0d67af3 to addbf68 Compare October 27, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants