Skip to content

fix(TextView): Clamp FirstVisibleLine #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mstv
Copy link
Member

@mstv mstv commented Jul 4, 2025

Hopefully fixes: At a first glance, it looked like no diff was displayed under some circumstances, which occurred several times in a new project at work (WSL?).
Though, those diffs were just scrolled to the very bottom.

Proposed changes

TextView: Clamp FirstVisibleLine instead of effectively displaying nothing

Before

image

After

image

@mstv mstv self-assigned this Jul 4, 2025
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment would be helpful

instead of effectively displaying nothing
@mstv mstv force-pushed the fix/invisible_diff branch from 928d859 to be6183d Compare July 6, 2025 12:58
Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think I have seen the problem, but why not add some more fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants