feat: indexer v2 query migrations #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| id | ||
| metadata | ||
| } | ||
| } | ||
| } | ||
| `; | ||
|
|
||
| //NOT SUPPORTED ON THE CURRENT INDEXER |
There was a problem hiding this comment.
^ what's the best way to do this instead ?
There was a problem hiding this comment.
can we make use of the events_registry here?
There was a problem hiding this comment.
i will add it to expose it on the hasura api
| @@ -604,13 +613,14 @@ export const getBlockNumberQuery = gql` | |||
| } | |||
| `; | |||
|
|
|||
| //TODO: migrate code in which this query is called | |||
| @@ -136,6 +143,7 @@ export const getProjectAnchorByIdAndChainId = gql` | |||
| * | |||
| * @returns The project | |||
| */ | |||
| //FIXME: Deprecated on indexer v2 ? | |||
There was a problem hiding this comment.
We'd have to fetch all projects and do the filter on the frontend right ?
There was a problem hiding this comment.
On indexer v2 we don't consider allo-v1 projects. But i saw that the legacyProjects table is straight forward to implement, will do it.
thelostone-mc
force-pushed
the
feat/indexerv2-integration
branch
from
9436e39 to
2724d6a
Compare
| @@ -326,7 +329,7 @@ export const getApprovedApplication = gql` | |||
| roundMetadata | |||
| } | |||
| metadata | |||
| project: canonicalProject { | |||
| project { | |||
There was a problem hiding this comment.
^ switch back to canonical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update queries for Indexer V2 compatibility
Changes
Testing
Look Into