Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: complete svelte-5 migration #5395

Closed
wants to merge 13 commits into from
Closed

feat: complete svelte-5 migration #5395

wants to merge 13 commits into from

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Nov 1, 2024

☕️ Reasoning

  • Run svelte auto migrate script (pnpm dlx sv migrate svelte-5)
  • Bump svelte and related dependencies in pnpm-workspace.yml
  • Bump pnpm corepack version in root package.json
  • Manually cleaned up a bunch of other things

Migration Guide: https://svelte.dev/docs/svelte/v5-migration-guide

🧢 Changes

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 5:50pm

@ndom91 ndom91 changed the title migrate-svelte-5 feat: complete svelte-5 migration Nov 1, 2024
@ndom91 ndom91 marked this pull request as draft November 1, 2024 14:24
Discard changes to apps/desktop/src/lib/branch/StackingSeriesDescription.svelte
Discard changes to apps/desktop/src/lib/branch/StackingSeriesHeader.svelte
Discard changes to apps/desktop/src/lib/commit/StackingCommitCard.svelte
Discard changes to apps/desktop/src/lib/commit/StackingUpstreamCommitsAccordion.svelte
Discard changes to apps/desktop/src/lib/components/AIPromptEdit/DialogBubble.svelte
Discard changes to apps/desktop/src/lib/components/InsertEmptyCommitAction.svelte
Discard changes to apps/desktop/src/lib/components/contextmenu/ContextMenuItem.svelte
Discard changes to apps/desktop/src/lib/dropzone/LineOverlay.svelte
Discard changes to apps/desktop/src/lib/navigation/DomainButton.svelte
Discard changes to apps/desktop/src/lib/select/OptionsGroup.svelte
fix: revert more :global css
@krlvi
Copy link
Member

krlvi commented Nov 2, 2024

Realistically, we should land this after we have released the tauri v2 changes

@ndom91
Copy link
Contributor Author

ndom91 commented Nov 3, 2024

Realistically, we should land this after we have released the tauri v2 changes

Yeah no rush, whenever makes the most sense 👍

Having tauri v2 released in a GA release for a bit first sounds reasonable

@ndom91
Copy link
Contributor Author

ndom91 commented Nov 28, 2024

Replaced by #5709

@ndom91 ndom91 closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants