Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 #92
base: main
Are you sure you want to change the base?
V2 #92
Changes from all commits
a384835
7633f71
da2b7f8
eaec69c
2615876
ff5e9a8
239ae67
405eb84
ce0ea59
85ae163
a366ee0
e729751
4b19876
b854d4a
eb5d63e
ad5bf23
e604961
5bf40a7
3a0b7cf
3c6d920
56d8314
770b1cb
4f01dbe
00d4c1f
cdc227a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 OpenAI
The logic for querying the verses and handling the case when no verses are found is incorrect. The SQLAlchemy
all()
method returns an empty list when no results are found, notNone
. Therefore, the conditionif verses is None:
will never be true even if no verses are found. You should check if the list is empty instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 OpenAI
Similar to the previous issue, the SQLAlchemy
first()
method returnsNone
when no results are found. So, the conditionif verse is None:
is correct in this case. However, you're calling.all()
onverse.translations
andverse.commentaries
, which could potentially returnNone
if there are no translations or commentaries. It would be better to handle these cases to avoid potentialAttributeError
s.