Optimize rounding of the welcome window #462
Merged
+143
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you test the change on 10.8, 10.9, 10.10, 10.11, 10.12? |
|
I'm currently spinning up VMs to test, feel free to block merge until I do so. I have confirmation from 10.13 (screenshot incoming shortly), and CI passed under 10.9. |
|
10.13 |
|
10.8 |
|
Excellent work, thanks much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mojave uses a (non-changeable) window backing that breaks how the welcome window is rounded off. This changes follows the pattern of Xcode's own welcome window by making the window clear and drawing the custom background with a box. This has the upshot of automatically using optimized drawing (layer backing) on OS' where that's available.
Before and after screenshots:
I AGREE TO THE GITUP CONTRIBUTOR LICENSE AGREEMENT